[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 120481: Do not skip searching for X11 and Wayland modules on Windows
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-10-06 12:56:32
Message-ID: 20141006125632.10360.65338 () probe ! kde ! org
[Download RAW message or body]
--===============3053670302151445371==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120481/#review67983
-----------------------------------------------------------
Please also get the feedback from the windows developers.
For Wayland I'm fine with the change - it should not exist for Windows and yes it \
should fail in that case. For the XCB one I'm a little bit doubtful in what it might \
result in. XCB should be available on Windows through the cygwin project, so in \
theory it might be possible to compile on Windows (and OSX) with XCB support. My fear \
is that incorrect usage downstream might result in undefined behavior if XCB is \
found. We still have too many incorrect ports from the old #ifdef Q_WS_X11 without a \
proper runtime check. So on that part we need the opinion of the Windows developers \
on how dangerous this could be.
- Martin Gräßlin
On Oct. 3, 2014, 6:19 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120481/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 6:19 p.m.)
>
>
> Review request for Extra Cmake Modules and Martin Gräßlin.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> While the search is unlikely to succeed on Windows, having different
> behaviour between the platforms (eg: find_package(Wayland REQUIRED) was
> not fatal on Windows, even though Wayland_FOUND would always be FALSE)
> is not ideal, and if someone did port them to Windows for some reason,
> the find modules should support that.
>
> If applications actually want different behaviour between platforms
> (like requiring a module on Unix, but not on Windows), they should
> implement that logic themselves (since they will have to deal with
> targets not being defined, etc, anyway).
>
>
> Diffs
> -----
>
> find-modules/FindEGL.cmake f1962b9abc7fef381efe073c1ce18379ab2a47da
> find-modules/FindWayland.cmake 11716f04444497db380e94b3d8ef69f41546f789
> find-modules/FindX11_XCB.cmake 05d18d5adfd197fea4f0c7defbe53da776ebac79
> find-modules/FindXCB.cmake 76d69fd790fb4831abd8a8351a684b97f6816081
>
> Diff: https://git.reviewboard.kde.org/r/120481/diff/
>
>
> Testing
> -------
>
> None whatsoever, since I want Martin's feedback on the idea first.
>
>
> Thanks,
>
> Alex Merry
>
>
--===============3053670302151445371==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120481/">https://git.reviewboard.kde.org/r/120481/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please also get the feedback from the windows developers.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">For Wayland I'm fine with the change - it should not exist for Windows and \
yes it should fail in that case. For the XCB one I'm a little bit doubtful in what it \
might result in. XCB should be available on Windows through the cygwin project, so in \
theory it might be possible to compile on Windows (and OSX) with XCB support. My fear \
is that incorrect usage downstream might result in undefined behavior if XCB is \
found. We still have too many incorrect ports from the old #ifdef Q_WS_X11 without a \
proper runtime check. So on that part we need the opinion of the Windows developers \
on how dangerous this could be.</p></pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On October 3rd, 2014, 6:19 p.m. CEST, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules and Martin Gräßlin.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2014, 6:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While the search is unlikely to succeed on Windows, \
having different behaviour between the platforms (eg: find_package(Wayland REQUIRED) \
was not fatal on Windows, even though Wayland_FOUND would always be FALSE)
is not ideal, and if someone did port them to Windows for some reason,
the find modules should support that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If applications actually want different behaviour \
between platforms (like requiring a module on Unix, but not on Windows), they should
implement that logic themselves (since they will have to deal with
targets not being defined, etc, anyway).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">None whatsoever, since I want Martin's feedback on the \
idea first.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindEGL.cmake <span style="color: \
grey">(f1962b9abc7fef381efe073c1ce18379ab2a47da)</span></li>
<li>find-modules/FindWayland.cmake <span style="color: \
grey">(11716f04444497db380e94b3d8ef69f41546f789)</span></li>
<li>find-modules/FindX11_XCB.cmake <span style="color: \
grey">(05d18d5adfd197fea4f0c7defbe53da776ebac79)</span></li>
<li>find-modules/FindXCB.cmake <span style="color: \
grey">(76d69fd790fb4831abd8a8351a684b97f6816081)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120481/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3053670302151445371==--
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic