[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-05-29 15:25:48
Message-ID: 20140529152548.14701.36487 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 29, 2014, 2:30 p.m., David Edmundson wrote:
> > > Unfortunately this way we cannot have a plural aware suffix.
> >
> > Then why port away?
> > Linking against kde4libsupport seems like the lesser of two evils.
>
> Aleix Pol Gonzalez wrote:
> Well then we need to decide how we're going to get to the proper fix. We can't just \
> decide it's good enough to depend on kdelibs4.
> David Edmundson wrote:
> We also can't just break things.
>
> Options are:
> 1) restore KIntSpinBox to kwidgetaddons
> 2) fix Qt, and drop the lib dependency once we have 5.4
>
> I was just looking at Qt translator code. Detecting if something is singular or \
> plural is not an easy task, and you need to have the locale tell you. There's not a \
> nice system that fits in with Qt's API. I guess we can file a bug report anyway and \
> see what happens.
>
Qt bug opened https://bugreports.qt-project.org/browse/QTBUG-39356
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/#review58724
-----------------------------------------------------------
On May 27, 2014, 12:04 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118347/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 12:04 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> [klipper] Port from KIntSpinBox to QSpinBox
>
> Unfortunately this way we cannot have a plural aware suffix.
>
>
> Diffs
> -----
>
> klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be
> klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588
>
> Diff: https://git.reviewboard.kde.org/r/118347/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118347/">https://git.reviewboard.kde.org/r/118347/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 29th, 2014, 2:30 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">>Unfortunately this way we cannot have a plural aware suffix.
Then why port away?
Linking against kde4libsupport seems like the lesser of two evils. </pre>
</blockquote>
<p>On May 29th, 2014, 2:37 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well then we need to \
decide how we're going to get to the proper fix. We can't just decide \
it's good enough to depend on kdelibs4.</pre> </blockquote>
<p>On May 29th, 2014, 2:52 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We also can't just \
break things.
Options are:
1) restore KIntSpinBox to kwidgetaddons
2) fix Qt, and drop the lib dependency once we have 5.4
I was just looking at Qt translator code. Detecting if something is singular or \
plural is not an easy task, and you need to have the locale tell you. There's not \
a nice system that fits in with Qt's API. I guess we can file a bug report anyway \
and see what happens.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Qt bug opened \
https://bugreports.qt-project.org/browse/QTBUG-39356</pre> <br />
<p>- David</p>
<br />
<p>On May 27th, 2014, 12:04 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 27, 2014, 12:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Port from KIntSpinBox to QSpinBox
Unfortunately this way we cannot have a plural aware suffix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/configdialog.cpp <span style="color: \
grey">(15901992db8d6fe28d800c4a18a3a6529cace1be)</span></li>
<li>klipper/generalconfig.ui <span style="color: \
grey">(f0145752eb2dbd927392b682b6472695c793a588)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118347/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic