From kde-panel-devel Thu May 29 15:25:48 2014 From: "David Edmundson" Date: Thu, 29 May 2014 15:25:48 +0000 To: kde-panel-devel Subject: Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox Message-Id: <20140529152548.14701.36487 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140137717213300 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1232753145717929638==" --===============1232753145717929638== Content-Type: multipart/alternative; boundary="===============3663799516277846882==" --===============3663799516277846882== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On May 29, 2014, 2:30 p.m., David Edmundson wrote: > > >Unfortunately this way we cannot have a plural aware suffix. > > > > Then why port away? > > Linking against kde4libsupport seems like the lesser of two evils. > > Aleix Pol Gonzalez wrote: > Well then we need to decide how we're going to get to the proper fix. We can't just decide it's good enough to depend on kdelibs4. > > David Edmundson wrote: > We also can't just break things. > > Options are: > 1) restore KIntSpinBox to kwidgetaddons > 2) fix Qt, and drop the lib dependency once we have 5.4 > > I was just looking at Qt translator code. Detecting if something is singular or plural is not an easy task, and you need to have the locale tell you. There's not a nice system that fits in with Qt's API. I guess we can file a bug report anyway and see what happens. > > Qt bug opened https://bugreports.qt-project.org/browse/QTBUG-39356 - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review58724 ----------------------------------------------------------- On May 27, 2014, 12:04 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118347/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 12:04 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > [klipper] Port from KIntSpinBox to QSpinBox > > Unfortunately this way we cannot have a plural aware suffix. > > > Diffs > ----- > > klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be > klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 > > Diff: https://git.reviewboard.kde.org/r/118347/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > > --===============3663799516277846882== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/

On May 29th, 2014, 2:30 p.m. UTC, David Edmundson wrote:

>Unfortunately this way we cannot have a plural aware suffix.

Then why port away?
Linking against kde4libsupport seems like the lesser of two evils.

On May 29th, 2014, 2:37 p.m. UTC, Aleix Pol Gonzalez wrote:

Well then we need to decide how we're going to get to the proper fix. We can't just decide it's good enough to depend on kdelibs4.

On May 29th, 2014, 2:52 p.m. UTC, David Edmundson wrote:

We also can't just break things.

Options are:
 1) restore KIntSpinBox to kwidgetaddons
 2) fix Qt, and drop the lib dependency once we have 5.4

I was just looking at Qt translator code. Detecting if something is singular or plural is not an easy task, and you need to have the locale tell you. There's not a nice system that fits in with Qt's API. I guess we can file a bug report anyway and see what happens.


Qt bug opened https://bugreports.qt-project.org/browse/QTBUG-39356

- David


On May 27th, 2014, 12:04 p.m. UTC, Martin Gräßlin wrote:

Review request for Plasma.
By Martin Gräßlin.

Updated May 27, 2014, 12:04 p.m.

Repository: plasma-workspace

Description 

[klipper] Port from KIntSpinBox to QSpinBox

Unfortunately this way we cannot have a plural aware suffix.

Diffs

  • klipper/configdialog.cpp (15901992db8d6fe28d800c4a18a3a6529cace1be)
  • klipper/generalconfig.ui (f0145752eb2dbd927392b682b6472695c793a588)

View Diff
--===============3663799516277846882==-- --===============1232753145717929638== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1232753145717929638==--