This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/ |
On May 29th, 2014, 2:30 p.m. UTC, David Edmundson wrote:
>Unfortunately this way we cannot have a plural aware suffix. Then why port away? Linking against kde4libsupport seems like the lesser of two evils.On May 29th, 2014, 2:37 p.m. UTC, Aleix Pol Gonzalez wrote:
Well then we need to decide how we're going to get to the proper fix. We can't just decide it's good enough to depend on kdelibs4.On May 29th, 2014, 2:52 p.m. UTC, David Edmundson wrote:
We also can't just break things. Options are: 1) restore KIntSpinBox to kwidgetaddons 2) fix Qt, and drop the lib dependency once we have 5.4 I was just looking at Qt translator code. Detecting if something is singular or plural is not an easy task, and you need to have the locale tell you. There's not a nice system that fits in with Qt's API. I guess we can file a bug report anyway and see what happens.
Qt bug opened https://bugreports.qt-project.org/browse/QTBUG-39356
- David
On May 27th, 2014, 12:04 p.m. UTC, Martin Gräßlin wrote:
Review request for Plasma.
By Martin Gräßlin.
Updated May 27, 2014, 12:04 p.m.
Repository:
plasma-workspace
Description
Diffs
|