'Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralAwareSpinBox'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralAwareSpinBox
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-06-03 5:48:14
Message-ID: 20140603054814.19148.25074 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/
-----------------------------------------------------------

(Updated June 3, 2014, 7:48 a.m.)

Review request for Plasma.

Changes
-------

ported to new KPluralAwareSpinBox which supports the plural base again. Has commit \
embargo till after beta release as it's not yet in frameworks beta release.

Summary (updated)
-----------------

[klipper] Port from KIntSpinBox to KPluralAwareSpinBox

Repository: plasma-workspace

Description (updated)
-------

[klipper] Port from KIntSpinBox to KPluralAwareSpinBox

This introduces new dependency to KF5TextWidgets.

REVIEW: 118347

Diffs (updated)
-----

  klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
  klipper/CMakeLists.txt 87e24724c99adde236c3479c13faca1c8f6c8b51 
  CMakeLists.txt 1f507a88f60188d34761a7a1eab95b33abd1f783 

Diff: https://git.reviewboard.kde.org/r/118347/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118347/">https://git.reviewboard.kde.org/r/118347/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated June 3, 2014, 7:48 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ported to new KPluralAwareSpinBox which supports the plural base again. \
Has commit embargo till after beta release as it&#39;s not yet in frameworks beta \
release.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Port from KIntSpinBox to KPluralAwareSpinBox</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Port from KIntSpinBox to KPluralAwareSpinBox

This introduces new dependency to KF5TextWidgets.

REVIEW: 118347</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>klipper/generalconfig.ui <span style="color: \
grey">(f0145752eb2dbd927392b682b6472695c793a588)</span></li>

 <li>klipper/CMakeLists.txt <span style="color: \
grey">(87e24724c99adde236c3479c13faca1c8f6c8b51)</span></li>

 <li>CMakeLists.txt <span style="color: \
grey">(1f507a88f60188d34761a7a1eab95b33abd1f783)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118347/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 