[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix ordinal suffix in plasmaclock configuration
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-25 12:57:16
Message-ID: 20111025125716.13428.69652 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102878/#review7604
-----------------------------------------------------------
a different approach to this problem can be found in this review: https://g=
it.reviewboard.kde.org/r/102944/ =
it's a good solution that resolves a number of issues (though limiting the =
flexibility i suppose?) so i'll mark this one as discarded in favor of 1029=
44.
thanks for the patches and comments everyone! :)
- Aaron J. Seigo
On Oct. 15, 2011, 10:38 p.m., Trever Fischer wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102878/
> -----------------------------------------------------------
> =
> (Updated Oct. 15, 2011, 10:38 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Does pretty much what it says on the tin.
> =
> No more strings that say "2th". Fixed to handle 1st, 2nd, 3rd, 282nd, 12t=
h, etc.
> =
> Brought up by this reddit thread: http://www.reddit.com/r/linux/comments/=
ld8ow/really_kde/
> =
> =
> Diffs
> -----
> =
> libs/plasmaclock/clockapplet.h ed6230f =
> libs/plasmaclock/clockapplet.cpp 4f16cb1 =
> =
> Diff: http://git.reviewboard.kde.org/r/102878/diff/diff
> =
> =
> Testing
> -------
> =
> Spun the spinbox.
> =
> =
> Thanks,
> =
> Trever Fischer
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102878/">http://git.reviewboard.kde.org/r/102878/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a different approach to \
this problem can be found in this review: https://git.reviewboard.kde.org/r/102944/
it's a good solution that resolves a number of issues (though limiting the \
flexibility i suppose?) so i'll mark this one as discarded in favor of 102944.
thanks for the patches and comments everyone! :)</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On October 15th, 2011, 10:38 p.m., Trever Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Trever Fischer.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2011, 10:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Does pretty much what it says on the tin.
No more strings that say "2th". Fixed to handle 1st, 2nd, 3rd, 282nd, 12th, \
etc.
Brought up by this reddit thread: \
http://www.reddit.com/r/linux/comments/ld8ow/really_kde/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Spun the spinbox.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/clockapplet.h <span style="color: grey">(ed6230f)</span></li>
<li>libs/plasmaclock/clockapplet.cpp <span style="color: grey">(4f16cb1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102878/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic