From kde-panel-devel Tue Oct 25 12:57:16 2011 From: "Aaron J. Seigo" Date: Tue, 25 Oct 2011 12:57:16 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix ordinal suffix in plasmaclock configuration Message-Id: <20111025125716.13428.69652 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131954748331351 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6300123198221249804==" --===============6300123198221249804== Content-Type: multipart/alternative; boundary="===============6781845703510087998==" --===============6781845703510087998== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102878/#review7604 ----------------------------------------------------------- a different approach to this problem can be found in this review: https://g= it.reviewboard.kde.org/r/102944/ = it's a good solution that resolves a number of issues (though limiting the = flexibility i suppose?) so i'll mark this one as discarded in favor of 1029= 44. thanks for the patches and comments everyone! :) - Aaron J. Seigo On Oct. 15, 2011, 10:38 p.m., Trever Fischer wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102878/ > ----------------------------------------------------------- > = > (Updated Oct. 15, 2011, 10:38 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Does pretty much what it says on the tin. > = > No more strings that say "2th". Fixed to handle 1st, 2nd, 3rd, 282nd, 12t= h, etc. > = > Brought up by this reddit thread: http://www.reddit.com/r/linux/comments/= ld8ow/really_kde/ > = > = > Diffs > ----- > = > libs/plasmaclock/clockapplet.h ed6230f = > libs/plasmaclock/clockapplet.cpp 4f16cb1 = > = > Diff: http://git.reviewboard.kde.org/r/102878/diff/diff > = > = > Testing > ------- > = > Spun the spinbox. > = > = > Thanks, > = > Trever Fischer > = > --===============6781845703510087998== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102878/ 

a differen=
t approach to this problem can be found in this review: https://git.reviewb=
oard.kde.org/r/102944/ =


it's a good solution that resolves a number of issues (though limiting =
the flexibility i suppose?) so i'll mark this one as discarded in favor=
 of 102944.

thanks for the patches and comments everyone! :)

- Aaron J.


On October 15th, 2011, 10:38 p.m., Trever Fischer wrote:

Review request for Plasma.
By Trever Fischer.

Updated Oct. 15, 2011, 10:38 p.m.

Descripti= on 

Does pretty much what it says on the tin.

No more strings that say "2th". Fixed to handle 1st, 2nd, 3rd, 28=
2nd, 12th, etc.

Brought up by this reddit thread: http://www.reddit.com/r/linux/comments/ld=
8ow/really_kde/

Testing <= /h1> 
Spun the spinbox.

Diffs=

  • libs/plasmaclock/clockapplet.h (ed6230f)
  • libs/plasmaclock/clockapplet.cpp (4f16cb1)=

View Diff
--===============6781845703510087998==-- --===============6300123198221249804== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6300123198221249804==--