This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102878/

a different approach to this problem can be found in this review: https://git.reviewboard.kde.org/r/102944/ 

it's a good solution that resolves a number of issues (though limiting the flexibility i suppose?) so i'll mark this one as discarded in favor of 102944.

thanks for the patches and comments everyone! :)

- Aaron J.


On October 15th, 2011, 10:38 p.m., Trever Fischer wrote:

Review request for Plasma.
By Trever Fischer.

Updated Oct. 15, 2011, 10:38 p.m.

Description

Does pretty much what it says on the tin.

No more strings that say "2th". Fixed to handle 1st, 2nd, 3rd, 282nd, 12th, etc.

Brought up by this reddit thread: http://www.reddit.com/r/linux/comments/ld8ow/really_kde/

Testing

Spun the spinbox.

Diffs

  • libs/plasmaclock/clockapplet.h (ed6230f)
  • libs/plasmaclock/clockapplet.cpp (4f16cb1)

View Diff