[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Update UI for settings of "Speak Time" in digital
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-25 12:55:36
Message-ID: 20111025125536.13213.19098 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102944/#review7603
-----------------------------------------------------------
Ship it!
Ship It!
- Aaron J. Seigo
On Oct. 23, 2011, 1:11 a.m., David Edmundson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102944/
> -----------------------------------------------------------
> =
> (Updated Oct. 23, 2011, 1:11 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> A rewrite of https://git.reviewboard.kde.org/r/102878/ fixes suffixes by =
rewriting it into "every 2 minutes" rather than "every 2th (or 2nd) minutes=
" which is far more translatable.
> =
> Also restricts input to a smaller range of sane values. It makes /no/ sen=
se to have something that isn't a factor of 60, as otherwise you get a long=
er gap between intervals when the hour comes round. This makes it easier fo=
r a user to select something sensible. Allowing these as inputs is wrong. A=
s an additional bonus it now reads "Every hour" rather than "60 minutes" wh=
ich is more intuitive.
> =
> =
> Diffs
> -----
> =
> libs/plasmaclock/clockapplet.cpp 4f16cb1 =
> libs/plasmaclock/generalConfig.ui aae25c0 =
> =
> Diff: http://git.reviewboard.kde.org/r/102944/diff/diff
> =
> =
> Testing
> -------
> =
> Tested that it loads saves correctly. Also tried loading from a config fi=
le which had a value not in my combo box. This is an incredibly unlikely se=
tup (which is why I'm changing it). It simply reverts back to being set to =
"Never" the first time they open the config, allowing them to set something=
else.
> =
> =
> Screenshots
> -----------
> =
> =
> http://git.reviewboard.kde.org/r/102944/s/314/
> =
> =
> Thanks,
> =
> David Edmundson
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102944/">http://git.reviewboard.kde.org/r/102944/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On October 23rd, 2011, 1:11 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2011, 1:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A rewrite of https://git.reviewboard.kde.org/r/102878/ fixes suffixes by \
rewriting it into "every 2 minutes" rather than "every 2th (or 2nd) \
minutes" which is far more translatable.
Also restricts input to a smaller range of sane values. It makes /no/ sense to have \
something that isn't a factor of 60, as otherwise you get a longer gap between \
intervals when the hour comes round. This makes it easier for a user to select \
something sensible. Allowing these as inputs is wrong. As an additional bonus it now \
reads "Every hour" rather than "60 minutes" which is more \
intuitive.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested that it loads saves correctly. Also tried loading from a config \
file which had a value not in my combo box. This is an incredibly unlikely setup \
(which is why I'm changing it). It simply reverts back to being set to \
"Never" the first time they open the config, allowing them to set something \
else.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/clockapplet.cpp <span style="color: grey">(4f16cb1)</span></li>
<li>libs/plasmaclock/generalConfig.ui <span style="color: \
grey">(aae25c0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102944/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102944/s/314/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/10/23/new_digital_clock_settings_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic