[prev in list] [next in list] [prev in thread] [next in thread]
List: cairo
Subject: Re: [cairo] color emoji support broken
From: Matthias Clasen <matthias.clasen () gmail ! com>
Date: 2019-05-31 12:29:52
Message-ID: CAFwd_vDD+u_pu86EJoKsVFoqOA46Qzo_-cAdx=ymUG+LuQcDFg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Thanks,
I later learned that there is already an MR for fixing this issue, by
Florian Muellner.
On Thu, May 30, 2019 at 11:37 PM suzuki toshiya <mpsuzuki@hiroshima-u.ac.jp>
wrote:
> According to the commit log when FT_PIXEL_MODE_BGRA was introduced to
> FreeType,
>
>
> https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=760d342d37ec9b26420956e3421075d410571b65
>
> FT_LOAD_COLOR macro (which we can test its availability by #ifdef) was
> introdcued
> at the same time. So replacing "#ifdef FT_PIXEL_MODE_BGRA" by "#ifdef
> FT_LOAD_COLOR"
> would resolve this bug. Just I've submitted a merge request:
>
> https://gitlab.freedesktop.org/cairo/cairo/merge_requests/25/diffs
>
> Sincerely I apologize the trouble I caused, and thank to Matthias for
> finding
> this. I cannot thank you enoughly.
>
> Regards,
> mpsuzuki
>
>
> suzuki toshiya wrote:
> > Dear Matthias,
> >
> > Ahhh, I'm quite sorry. Using "ifdef" is not good to check the
> availability of
> > FT_PIXEL_MODE_BGRA.
> > This is an integer value declared as
> >
> > typedef enum FT_Pixel_Mode_
> > {
> > FT_PIXEL_MODE_NONE = 0,
> > FT_PIXEL_MODE_MONO,
> > FT_PIXEL_MODE_GRAY,
> > FT_PIXEL_MODE_GRAY2,
> > FT_PIXEL_MODE_GRAY4,
> > FT_PIXEL_MODE_LCD,
> > FT_PIXEL_MODE_LCD_V,
> > FT_PIXEL_MODE_BGRA,
> >
> > FT_PIXEL_MODE_MAX /* do not remove */
> >
> > } FT_Pixel_Mode;
> >
> > #ifdef is not good. Soon I would post a fix for that, by better
> configure script.
> >
> > Regardss,
> > mpsuzuki
> >
> > suzuki toshiya wrote:
> > > Dear Mattias,
> > >
> > > Maybe this commit?
> > >
> > >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.o \
> rg%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa31526443f7c&data=02%7 \
> C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca27c4496b21a308d6e5747ea5%7Cc40454ddb263 \
> 4926868d8e12640d3750%7C1%7C0%7C636948685861037983&sdata=VzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow%3D&reserved=0
>
> > >
> > > Sorry, please let me know more about your trouble.
> > >
> > > > This breaks color Emoji support since the freetype headers don't
> define this.
> > > If so, and if we revert this, following "case FT_PIXEL_MODE_BGRA" would
> cause a compilation error?
> > >
> > > Regards,
> > > mpsuzuki
> > >
> > > On 2019/05/31 2:09, Matthias Clasen wrote:
> > > > Some recent commit introduced an
> > > >
> > > > #ifdef FT_PIXEL_MODE_BGRA
> > > >
> > > > This breaks color Emoji support since the freetype headers don't
> define this.
> > > >
> > > > Please revert
> > > >
> --
> cairo mailing list
> cairo@cairographics.org
> https://lists.cairographics.org/mailman/listinfo/cairo
[Attachment #5 (text/html)]
<div dir="ltr"><div>Thanks,</div><div><br></div><div>I later learned that there is \
already an MR for fixing this issue, by Florian Muellner.<br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 30, 2019 at 11:37 \
PM suzuki toshiya <<a \
href="mailto:mpsuzuki@hiroshima-u.ac.jp">mpsuzuki@hiroshima-u.ac.jp</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">According to the \
commit log when FT_PIXEL_MODE_BGRA was introduced to FreeType,<br> <br>
<a href="https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=760d342d37ec9b26420956e3421075d410571b65" \
rel="noreferrer" target="_blank">https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=760d342d37ec9b26420956e3421075d410571b65</a><br>
<br>
FT_LOAD_COLOR macro (which we can test its availability by #ifdef) was introdcued<br>
at the same time. So replacing "#ifdef FT_PIXEL_MODE_BGRA" by "#ifdef \
FT_LOAD_COLOR"<br> would resolve this bug. Just I've submitted a merge \
request:<br> <br>
<a href="https://gitlab.freedesktop.org/cairo/cairo/merge_requests/25/diffs" \
rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/cairo/cairo/merge_requests/25/diffs</a><br>
<br>
Sincerely I apologize the trouble I caused, and thank to Matthias for finding<br>
this. I cannot thank you enoughly.<br>
<br>
Regards,<br>
mpsuzuki<br>
<br>
<br>
suzuki toshiya wrote:<br>
> Dear Matthias,<br>
> <br>
> Ahhh, I'm quite sorry. Using "ifdef" is not good to check the \
availability of<br> > FT_PIXEL_MODE_BGRA.<br>
> This is an integer value declared as<br>
> <br>
> typedef enum FT_Pixel_Mode_<br>
> {<br>
> FT_PIXEL_MODE_NONE = 0,<br>
> FT_PIXEL_MODE_MONO,<br>
> FT_PIXEL_MODE_GRAY,<br>
> FT_PIXEL_MODE_GRAY2,<br>
> FT_PIXEL_MODE_GRAY4,<br>
> FT_PIXEL_MODE_LCD,<br>
> FT_PIXEL_MODE_LCD_V,<br>
> FT_PIXEL_MODE_BGRA,<br>
> <br>
> FT_PIXEL_MODE_MAX /* do not remove */<br>
> <br>
> } FT_Pixel_Mode;<br>
> <br>
> #ifdef is not good. Soon I would post a fix for that, by better configure \
script.<br> > <br>
> Regardss,<br>
> mpsuzuki<br>
> <br>
> suzuki toshiya wrote:<br>
>> Dear Mattias,<br>
>><br>
>> Maybe this commit?<br>
>><br>
>> <a href="https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcg \
it.freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa31526443f7c \
&amp;data=02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca27c4496b21a308d6e5747ea \
5%7Cc40454ddb2634926868d8e12640d3750%7C1%7C0%7C636948685861037983&amp;sdata=VzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow%3D&amp;reserved=0" \
rel="noreferrer" target="_blank">https://jpn01.safelinks.protection.outlook.com/?url=h \
ttps%3A%2F%2Fcgit.freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080a \
c3aa31526443f7c&amp;data=02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca27c4496b \
21a308d6e5747ea5%7Cc40454ddb2634926868d8e12640d3750%7C1%7C0%7C636948685861037983&a \
mp;sdata=VzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow%3D&amp;reserved=0</a><br> \
>><br> >> Sorry, please let me know more about your trouble.<br>
>><br>
>>> This breaks color Emoji support since the freetype headers don't \
define this.<br> >> If so, and if we revert this, following "case \
FT_PIXEL_MODE_BGRA" would cause a compilation error?<br> >><br>
>> Regards,<br>
>> mpsuzuki<br>
>><br>
>> On 2019/05/31 2:09, Matthias Clasen wrote:<br>
>>> Some recent commit introduced an<br>
>>><br>
>>> #ifdef FT_PIXEL_MODE_BGRA<br>
>>><br>
>>> This breaks color Emoji support since the freetype headers don't \
define this.<br> >>><br>
>>> Please revert<br>
>>><br>
-- <br>
cairo mailing list<br>
<a href="mailto:cairo@cairographics.org" \
target="_blank">cairo@cairographics.org</a><br> <a \
href="https://lists.cairographics.org/mailman/listinfo/cairo" rel="noreferrer" \
target="_blank">https://lists.cairographics.org/mailman/listinfo/cairo</a></blockquote></div>
[Attachment #6 (text/plain)]
--
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic