[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo
Subject:    Re: [cairo] color emoji support broken
From:       suzuki toshiya <mpsuzuki () hiroshima-u ! ac ! jp>
Date:       2019-05-31 3:37:08
Message-ID: 5CF09F52.40206 () hiroshima-u ! ac ! jp
[Download RAW message or body]

According to the commit log when FT_PIXEL_MODE_BGRA was introduced to FreeType,

https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=760d342d37ec9b26420956e3421075d410571b65


FT_LOAD_COLOR macro (which we can test its availability by #ifdef) was introdcued
at the same time. So replacing "#ifdef FT_PIXEL_MODE_BGRA" by "#ifdef FT_LOAD_COLOR"
would resolve this bug. Just I've submitted a merge request:

https://gitlab.freedesktop.org/cairo/cairo/merge_requests/25/diffs

Sincerely I apologize the trouble I caused, and thank to Matthias for finding
this. I cannot thank you enoughly.

Regards,
mpsuzuki


suzuki toshiya wrote:
> Dear Matthias,
> 
> Ahhh, I'm quite sorry. Using "ifdef" is not good to check the availability of
> FT_PIXEL_MODE_BGRA.
> This is an integer value declared as
> 
> typedef enum  FT_Pixel_Mode_
> {
> FT_PIXEL_MODE_NONE = 0,
> FT_PIXEL_MODE_MONO,
> FT_PIXEL_MODE_GRAY,
> FT_PIXEL_MODE_GRAY2,
> FT_PIXEL_MODE_GRAY4,
> FT_PIXEL_MODE_LCD,
> FT_PIXEL_MODE_LCD_V,
> FT_PIXEL_MODE_BGRA,
> 
> FT_PIXEL_MODE_MAX      /* do not remove */
> 
> } FT_Pixel_Mode;
> 
> #ifdef is not good. Soon I would post a fix for that, by better configure script.
> 
> Regardss,
> mpsuzuki
> 
> suzuki toshiya wrote:
> > Dear Mattias,
> > 
> > Maybe this commit?
> > 
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop \
> > .org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa31526443f7c&amp;data= \
> > 02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca27c4496b21a308d6e5747ea5%7Cc40454 \
> > ddb2634926868d8e12640d3750%7C1%7C0%7C636948685861037983&amp;sdata=VzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow%3D&amp;reserved=0
> >  
> > Sorry, please let me know more about your trouble.
> > 
> > > This breaks color Emoji support since the freetype headers don't define this.
> > If so, and if we revert this, following "case FT_PIXEL_MODE_BGRA" would cause a \
> > compilation error? 
> > Regards,
> > mpsuzuki
> > 
> > On 2019/05/31 2:09, Matthias Clasen wrote:
> > > Some recent commit introduced an
> > > 
> > > #ifdef FT_PIXEL_MODE_BGRA
> > > 
> > > This breaks color Emoji support since the freetype headers don't define this.
> > > 
> > > Please revert
> > > 
-- 
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo


[prev in list] [next in list] [prev in thread] [next in thread]