Thanks,

I later learned that= there is already an MR for fixing this issue, by Florian Muellner.

On Thu, May 30, 2019 at 11:37 PM suzuki toshiya <mpsuzuki@hiroshima-u.ac.jp> wrote:

According to the commit = log when FT_PIXEL_MODE_BGRA was introduced to FreeType,

https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit= /?id=3D760d342d37ec9b26420956e3421075d410571b65

FT_LOAD_COLOR macro (which we can test its availability by #ifdef) was intr= odcued
at the same time. So replacing "#ifdef FT_PIXEL_MODE_BGRA" by &qu= ot;#ifdef FT_LOAD_COLOR"
would resolve this bug. Just I've submitted a merge request:

https://gitlab.freedesktop.org/cai= ro/cairo/merge_requests/25/diffs

Sincerely I apologize the trouble I caused, and thank to Matthias for findi= ng
this. I cannot thank you enoughly.

Regards,
mpsuzuki

suzuki toshiya wrote:
> Dear Matthias,
>
> Ahhh, I'm quite sorry. Using "ifdef" is not good to chec= k the availability of
> FT_PIXEL_MODE_BGRA.
> This is an integer value declared as
>
>=C2=A0 =C2=A0typedef enum=C2=A0 FT_Pixel_Mode_
>=C2=A0 =C2=A0{
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_NONE =3D 0,
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_MONO,
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_GRAY,
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_GRAY2,
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_GRAY4,
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_LCD,
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_LCD_V,
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_BGRA,
>
>=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_MAX=C2=A0 =C2=A0 =C2=A0 /* do not rem= ove */
>
>=C2=A0 =C2=A0} FT_Pixel_Mode;
>
> #ifdef is not good. Soon I would post a fix for that, by better config= ure script.
>
> Regardss,
> mpsuzuki
>
> suzuki toshiya wrote:
>> Dear Mattias,
>>
>> Maybe this commit?
>>
>> https://jpn01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fcgi= t.freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa3= 1526443f7c&data=3D02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca= 27c4496b21a308d6e5747ea5%7Cc40454ddb2634926868d8e12640d3750%7C1%7C0%7C63694= 8685861037983&sdata=3DVzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow= %3D&reserved=3D0
>>
>> Sorry, please let me know more about your trouble.
>>
>>> This breaks color Emoji support since the freetype headers don= 't define this.
>> If so, and if we revert this, following "case FT_PIXEL_MODE_B= GRA" would cause a compilation error?
>>
>> Regards,
>> mpsuzuki
>>
>> On 2019/05/31 2:09, Matthias Clasen wrote:
>>> Some recent commit introduced an
>>>
>>> #ifdef FT_PIXEL_MODE_BGRA
>>>
>>> This breaks color Emoji support since the freetype headers don= 't define this.
>>>
>>> Please revert
>>>
--
cairo mailing list
cairo@cairogra= phics.org
https://lists.cairographics.org/mailman/listin= fo/cairo

--00000000000001b5b5058a2e2df6-- --===============1546275390== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline LS0gCmNhaXJvIG1haWxpbmcgbGlzdApjYWlyb0BjYWlyb2dyYXBoaWNzLm9yZwpodHRwczovL2xp c3RzLmNhaXJvZ3JhcGhpY3Mub3JnL21haWxtYW4vbGlzdGluZm8vY2Fpcm8= --===============1546275390==--