[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [valgrind] [Bug 345695] Add POWERPC support for AT_DCACHESIZE and HWCAP2
From:       Julian Seward <jseward () acm ! org>
Date:       2015-03-31 18:40:22
Message-ID: bug-345695-17878-v8pbIGr0Gc () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=345695

--- Comment #2 from Julian Seward <jseward@acm.org> ---
(In reply to Carl Love from comment #0)
> Created attachment 91822 [details]
> ADD AT_DCACHEBSIZE and AT_HWCAP2 support for POWER PC

Looks fine to me.  A couple of minor nits:

-IIFinaliseImageInfo VG_(ii_create_image)( IICreateImageInfo );
+IIFinaliseImageInfo VG_(ii_create_image)( IICreateImageInfo,
+                                          VexArchInfo vex_archinfo );

Pls pass the VexArchInfo around as a const VexArchInfo*, not by value.


+        vg_assert((vex_archinfo.hwcaps & VEX_HWCAPS_PPC64_ISA2_07) ==
VEX_HWCAPS_PPC64_ISA2_07);

Does this pass on Power7 and Power8 and on older targets?


The indentation in the patch is a bit krunky in a couple of places; making
it consistent would be nice.

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]