[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [valgrind] [Bug 345695] Add POWERPC support for AT_DCACHESIZE and HWCAP2
From:       Carl Love <cel () us ! ibm ! com>
Date:       2015-04-03 21:47:10
Message-ID: bug-345695-17878-xYu142cE2Y () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=345695

Carl Love <cel@us.ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91822|0                           |1
        is obsolete|                            |

--- Comment #3 from Carl Love <cel@us.ibm.com> ---
Created attachment 91873
  --> https://bugs.kde.org/attachment.cgi?id=91873&action=edit
ADD AT_DCACHEBSIZE and AT_HWCAP2 support for POWER PC

Updated patch to address previous comment.
> Looks fine to me.  A couple of minor nits:

>-IIFinaliseImageInfo VG_(ii_create_image)( IICreateImageInfo );
>+IIFinaliseImageInfo VG_(ii_create_image)( IICreateImageInfo,
>+                                          VexArchInfo vex_archinfo );

>Pls pass the VexArchInfo around as a const VexArchInfo*, not by value.

Change made as requested.

> +        vg_assert((vex_archinfo.hwcaps & VEX_HWCAPS_PPC64_ISA2_07) ==
>VEX_HWCAPS_PPC64_ISA2_07);

>Does this pass on Power7 and Power8 and on older targets?

The assert is inside the if statement "if ((auxv->u.a_val & ~(0x80000000ULL))
!= 0) {"
where the value 0x80000000 refers to the PPC_FEATURE2_ARCH_2_07 HW cap feature
as documented just above the if statement.  So, the feature will not exist on
the older architectures and thus the assert will not be executed on the older
platforms.   After updating the patch, it was retested on Power 6, Power 7,
Power 8 LE and Power 8 BE to verify hardware caps stuff works.

> The indentation in the patch is a bit krunky in a couple of places; making
> it consistent would be nice.

Yes, I found and fixed several issues with the indentation.  I believe it is
all OK now.  

Let me know if I got all the changes as you wanted them.  Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]