[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: LoadLibrary16 and GetModuleHandle16 behaviour
From:       Bertho Stultiens <bertho () panter ! soci ! aau ! dk>
Date:       1999-04-28 21:34:39
[Download RAW message or body]

Ulrich Weigand wrote:
> I'm not sure why you would want to parse filename components ...
> 
> The problem with LoadModule16 is simply that it is wrong to call
> GetModuleHandle there, but we need to implement the correct check
> (composed of (some of) the same checks as in GetModuleHandle, but
> applied in another sequence) there.
> 
> The only thing needed to 'parse' is to extract the base name, but
> that is rather trivial;  where do you think you need to parse the
> filename in more detail?

There was a problem in the loading of a printer driver. The file loaded
was xxxx.DRV.DRV. This actually succeeded until the new loader structure
called GetModuleHandle16 with the exact same path as it was loaded with.
The problem is that we are extracting extensions and basenames and
whatever from a path using local code that comes in many variations. The
above is an example of a bug, probably due to a strchr instead of
strrchr. I want to streamline this a bit to get it under control. I.e,
delete all the code searching for '/', '\\', ':'  and '.' and replace it
with one simple call.

Greetings Bertho


=========================================================================

[prev in list] [next in list] [prev in thread] [next in thread]