[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Having trouble building
From:       Maciej Stachowiak <mjs () apple ! com>
Date:       2019-10-06 23:04:51
Message-ID: C30A5DB0-027B-4FA5-8384-5E49111D152A () apple ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> On Oct 5, 2019, at 9:36 PM, Ken Russell <kbr@google.com> wrote:
> 
> On Sat, Oct 5, 2019 at 1:11 AM Tim Horton <timothy_horton@apple.com \
> <mailto:timothy_horton@apple.com>> wrote: 
> 
> > On Oct 4, 2019, at 8:55 PM, Ken Russell <kbr@google.com <mailto:kbr@google.com>> \
> > wrote: 
> > Hi,
> > 
> > Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree WebKit. With a \
> > clean WebKitBuild directory I'm seeing the following build error:
> 
> What OS are you on?
> 
> You might want to peek at https://bugs.webkit.org/show_bug.cgi?id=199705 \
> <https://bugs.webkit.org/show_bug.cgi?id=199705> 
> macOS 10.14.6, Xcode 11.0 from the App Store.
> 
> Looks like the same problem. Could anyone from Apple please try to help fix this? I \
> posted a hack workaround on the bug but don't know enough Objective-C to guess at a \
> correct fix.

Does the new patch from Mitz fix the build for you?

 - Maciej

> 
> Thanks,
> 
> -Ken
> 
> 
> > $ ./Tools/Scripts/build-webkit --release > build-log.txt
> > 
> > ...
> > 
> > In file included from \
> > /Users/kbr/src/WebKit/WebKitBuild/Release/DerivedSources/WebKitLegacy/unified-sources/UnifiedSource20-mm.mm:4:
> >  /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:5: \
> > error: use of undeclared identifier '_subviews'; did you mean 'subviews'? \
> > _subviews = subviews; ^~~~~~~~~
> > subviews
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:220:63: \
> >                 note: 'subviews' declared here
> > - (void)_setSubviewsIvar:(NSMutableArray<__kindof NSView *> *)subviews {
> > ^
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:15: \
> > error: explicitly assigning value of variable of type 'NSMutableArray<__kindof \
> > NSView *> *' to itself [-Werror,-Wself-assign] _subviews = subviews;
> > ~~~~~~~~~ ^ ~~~~~~~~
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:228:30: \
> > error: use of undeclared identifier '_subviews' return (NSMutableArray \
> > *)_subviews; ^
> > 3 errors generated.
> > 
> > 
> > 
> > Has anyone else run into this?
> > 
> > Thanks,
> > 
> > -Ken
> > 
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
> > https://lists.webkit.org/mailman/listinfo/webkit-dev \
> > <https://lists.webkit.org/mailman/listinfo/webkit-dev>
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


[Attachment #5 (unknown)]

<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; line-break: after-white-space;" class=""><br class=""><div><br \
class=""><blockquote type="cite" class=""><div class="">On Oct 5, 2019, at 9:36 PM, \
Ken Russell &lt;<a href="mailto:kbr@google.com" class="">kbr@google.com</a>&gt; \
wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" \
class=""><div dir="ltr" class="">On Sat, Oct 5, 2019 at 1:11 AM Tim Horton &lt;<a \
href="mailto:timothy_horton@apple.com" class="">timothy_horton@apple.com</a>&gt; \
wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><br class=""> <br class="">
&gt; On Oct 4, 2019, at 8:55 PM, Ken Russell &lt;<a href="mailto:kbr@google.com" \
target="_blank" class="">kbr@google.com</a>&gt; wrote:<br class=""> &gt; <br \
class=""> &gt; Hi,<br class="">
&gt; <br class="">
&gt; Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree WebKit. With a \
clean WebKitBuild directory I'm seeing the following build error:<br class=""> <br \
class=""> What OS are you on?<br class="">
<br class="">
You might want to peek at <a href="https://bugs.webkit.org/show_bug.cgi?id=199705" \
rel="noreferrer" target="_blank" \
class="">https://bugs.webkit.org/show_bug.cgi?id=199705</a></blockquote><div \
class=""><br class=""></div><div class="">macOS 10.14.6, Xcode 11.0 from the App \
Store.</div><div class=""><br class=""></div><div class="">Looks like the same \
problem. Could anyone from Apple please try to help fix this? I posted a hack \
workaround on the bug but don't know enough Objective-C to guess at a correct \
fix.</div></div></div></div></blockquote><div><br class=""></div><div>Does the new \
patch from Mitz fix the build for you?</div><div><br class=""></div><div>&nbsp;- \
Maciej</div><br class=""><blockquote type="cite" class=""><div class=""><div \
dir="ltr" class=""><div class="gmail_quote"><div class=""><br class=""></div><div \
class="">Thanks,</div><div class=""><br class=""></div><div class="">-Ken</div><div \
class=""><br class=""></div><div class="">&nbsp;</div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> &gt; $ ./Tools/Scripts/build-webkit --release \
&gt; build-log.txt<br class=""> &gt; <br class="">
&gt; ...<br class="">
&gt; <br class="">
&gt; In file included from \
/Users/kbr/src/WebKit/WebKitBuild/Release/DerivedSources/WebKitLegacy/unified-sources/UnifiedSource20-mm.mm:4:<br \
class=""> &gt; /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:5: \
error: use of undeclared identifier '_subviews'; did you mean 'subviews'?<br \
class=""> &gt;&nbsp; &nbsp; &nbsp;_subviews = subviews;<br class="">
&gt;&nbsp; &nbsp; &nbsp;^~~~~~~~~<br class="">
&gt;&nbsp; &nbsp; &nbsp;subviews<br class="">
&gt; /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:220:63: \
note: 'subviews' declared here<br class=""> &gt; - \
(void)_setSubviewsIvar:(NSMutableArray&lt;__kindof NSView *&gt; *)subviews {<br \
class=""> &gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;^<br class=""> \
&gt; /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:15: \
error: explicitly assigning value of variable of type 'NSMutableArray&lt;__kindof \
NSView *&gt; *' to itself [-Werror,-Wself-assign]<br class=""> &gt;&nbsp; &nbsp; \
&nbsp;_subviews = subviews;<br class=""> &gt;&nbsp; &nbsp; &nbsp;~~~~~~~~~ ^ \
~~~~~~~~<br class=""> &gt; \
/Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:228:30: error: \
use of undeclared identifier '_subviews'<br class=""> &gt;&nbsp; &nbsp; &nbsp;return \
(NSMutableArray *)_subviews;<br class=""> &gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ^<br class=""> \
&gt; 3 errors generated.<br class=""> &gt; <br class="">
&gt; <br class="">
&gt; <br class="">
&gt; Has anyone else run into this?<br class="">
&gt; <br class="">
&gt; Thanks,<br class="">
&gt; <br class="">
&gt; -Ken<br class="">
&gt; <br class="">
&gt; _______________________________________________<br class="">
&gt; webkit-dev mailing list<br class="">
&gt; <a href="mailto:webkit-dev@lists.webkit.org" target="_blank" \
class="">webkit-dev@lists.webkit.org</a><br class=""> &gt; <a \
href="https://lists.webkit.org/mailman/listinfo/webkit-dev" rel="noreferrer" \
target="_blank" class="">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br \
class=""> <br class="">
</blockquote></div></div>
_______________________________________________<br class="">webkit-dev mailing \
list<br class=""><a href="mailto:webkit-dev@lists.webkit.org" \
class="">webkit-dev@lists.webkit.org</a><br \
class="">https://lists.webkit.org/mailman/listinfo/webkit-dev<br \
class=""></div></blockquote></div><br class=""></body></html>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic