[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Having trouble building
From: Ken Russell <kbr () google ! com>
Date: 2019-10-07 18:10:55
Message-ID: CAMYvS2dDum+eQArXf1y+EfEb+PSoJ=nOXuaO5dRbPY-V3EZp7A () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Sun, Oct 6, 2019 at 4:05 PM Maciej Stachowiak <mjs@apple.com> wrote:
>
>
> On Oct 5, 2019, at 9:36 PM, Ken Russell <kbr@google.com> wrote:
>
> On Sat, Oct 5, 2019 at 1:11 AM Tim Horton <timothy_horton@apple.com>
> wrote:
>
> >
> >
> > > On Oct 4, 2019, at 8:55 PM, Ken Russell <kbr@google.com> wrote:
> > >
> > > Hi,
> > >
> > > Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree WebKit.
> > With a clean WebKitBuild directory I'm seeing the following build error:
> >
> > What OS are you on?
> >
> > You might want to peek at https://bugs.webkit.org/show_bug.cgi?id=199705
>
>
> macOS 10.14.6, Xcode 11.0 from the App Store.
>
> Looks like the same problem. Could anyone from Apple please try to help
> fix this? I posted a hack workaround on the bug but don't know enough
> Objective-C to guess at a correct fix.
>
>
> Does the new patch from Mitz fix the build for you?
>
Just updated the bug - Mitz's patch fixed the build, and incorporating
Alexey's suggestion should hopefully get it to pass the style checker.
Thanks everyone for your help!
-Ken
>
> - Maciej
>
>
> Thanks,
>
> -Ken
>
>
>
> > > $ ./Tools/Scripts/build-webkit --release > build-log.txt
> > >
> > > ...
> > >
> > > In file included from
> > /Users/kbr/src/WebKit/WebKitBuild/Release/DerivedSources/WebKitLegacy/unified-sources/UnifiedSource20-mm.mm:4:
> >
> > >
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:5:
> > error: use of undeclared identifier '_subviews'; did you mean 'subviews'?
> > > _subviews = subviews;
> > > ^~~~~~~~~
> > > subviews
> > >
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:220:63:
> > note: 'subviews' declared here
> > > - (void)_setSubviewsIvar:(NSMutableArray<__kindof NSView *> *)subviews {
> > > ^
> > >
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:15:
> > error: explicitly assigning value of variable of type
> > 'NSMutableArray<__kindof NSView *> *' to itself [-Werror,-Wself-assign]
> > > _subviews = subviews;
> > > ~~~~~~~~~ ^ ~~~~~~~~
> > >
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:228:30:
> > error: use of undeclared identifier '_subviews'
> > > return (NSMutableArray *)_subviews;
> > > ^
> > > 3 errors generated.
> > >
> > >
> > >
> > > Has anyone else run into this?
> > >
> > > Thanks,
> > >
> > > -Ken
> > >
> > > _______________________________________________
> > > webkit-dev mailing list
> > > webkit-dev@lists.webkit.org
> > > https://lists.webkit.org/mailman/listinfo/webkit-dev
> >
> > _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
>
[Attachment #5 (text/html)]
<div dir="ltr"><div dir="ltr">On Sun, Oct 6, 2019 at 4:05 PM Maciej Stachowiak <<a \
href="mailto:mjs@apple.com">mjs@apple.com</a>> wrote:<br></div><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
style="overflow-wrap: break-word;"><br><div><br><blockquote type="cite"><div>On Oct \
5, 2019, at 9:36 PM, Ken Russell <<a href="mailto:kbr@google.com" \
target="_blank">kbr@google.com</a>> wrote:</div><br><div><div dir="ltr"><div \
dir="ltr">On Sat, Oct 5, 2019 at 1:11 AM Tim Horton <<a \
href="mailto:timothy_horton@apple.com" \
target="_blank">timothy_horton@apple.com</a>> wrote:<br></div><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> <br>
> On Oct 4, 2019, at 8:55 PM, Ken Russell <<a href="mailto:kbr@google.com" \
target="_blank">kbr@google.com</a>> wrote:<br> > <br>
> Hi,<br>
> <br>
> Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree WebKit. With a \
clean WebKitBuild directory I'm seeing the following build error:<br> <br>
What OS are you on?<br>
<br>
You might want to peek at <a href="https://bugs.webkit.org/show_bug.cgi?id=199705" \
rel="noreferrer" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=199705</a></blockquote><div><br></div><div>macOS \
10.14.6, Xcode 11.0 from the App Store.</div><div><br></div><div>Looks like the same \
problem. Could anyone from Apple please try to help fix this? I posted a hack \
workaround on the bug but don't know enough Objective-C to guess at a correct \
fix.</div></div></div></div></blockquote><div><br></div><div>Does the new patch from \
Mitz fix the build for you?</div></div></div></blockquote><div><br></div><div>Just \
updated the bug - Mitz's patch fixed the build, and incorporating Alexey's \
suggestion should hopefully get it to pass the style checker. Thanks everyone for \
your help!</div><div><br></div><div>-Ken</div><div><br></div><div> \
<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
style="overflow-wrap: break-word;"><div><div><br></div><div> - \
Maciej</div><br><blockquote type="cite"><div><div dir="ltr"><div \
class="gmail_quote"><div><br></div><div>Thanks,</div><div><br></div><div>-Ken</div><div><br></div><div> \
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px \
solid rgb(204,204,204);padding-left:1ex"> > $ ./Tools/Scripts/build-webkit \
--release > build-log.txt<br> > <br>
> ...<br>
> <br>
> In file included from \
/Users/kbr/src/WebKit/WebKitBuild/Release/DerivedSources/WebKitLegacy/unified-sources/UnifiedSource20-mm.mm:4:<br>
> /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:5: \
error: use of undeclared identifier '_subviews'; did you mean \
'subviews'?<br> > _subviews = subviews;<br>
> ^~~~~~~~~<br>
> subviews<br>
> /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:220:63: \
note: 'subviews' declared here<br> > - \
(void)_setSubviewsIvar:(NSMutableArray<__kindof NSView *> *)subviews {<br> > \
^<br> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:15: \
error: explicitly assigning value of variable of type 'NSMutableArray<__kindof \
NSView *> *' to itself [-Werror,-Wself-assign]<br> > _subviews = \
subviews;<br> > ~~~~~~~~~ ^ ~~~~~~~~<br>
> /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:228:30: \
error: use of undeclared identifier '_subviews'<br> > return \
(NSMutableArray *)_subviews;<br> > \
^<br> > 3 errors generated.<br>
> <br>
> <br>
> <br>
> Has anyone else run into this?<br>
> <br>
> Thanks,<br>
> <br>
> -Ken<br>
> <br>
> _______________________________________________<br>
> webkit-dev mailing list<br>
> <a href="mailto:webkit-dev@lists.webkit.org" \
target="_blank">webkit-dev@lists.webkit.org</a><br> > <a \
href="https://lists.webkit.org/mailman/listinfo/webkit-dev" rel="noreferrer" \
target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br> <br>
</blockquote></div></div>
_______________________________________________<br>webkit-dev mailing list<br><a \
href="mailto:webkit-dev@lists.webkit.org" \
target="_blank">webkit-dev@lists.webkit.org</a><br><a \
href="https://lists.webkit.org/mailman/listinfo/webkit-dev" \
target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br></div></blockquote></div><br></div></blockquote></div></div>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic