--===============0963966880== Content-type: multipart/alternative; boundary="Apple-Mail=_A4D60106-6D35-4251-873C-7D531E15B3D6" --Apple-Mail=_A4D60106-6D35-4251-873C-7D531E15B3D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Oct 5, 2019, at 9:36 PM, Ken Russell wrote: >=20 > On Sat, Oct 5, 2019 at 1:11 AM Tim Horton > wrote: >=20 >=20 > > On Oct 4, 2019, at 8:55 PM, Ken Russell > wrote: > >=20 > > Hi, > >=20 > > Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree = WebKit. With a clean WebKitBuild directory I'm seeing the following = build error: >=20 > What OS are you on? >=20 > You might want to peek at = https://bugs.webkit.org/show_bug.cgi?id=3D199705 = >=20 > macOS 10.14.6, Xcode 11.0 from the App Store. >=20 > Looks like the same problem. Could anyone from Apple please try to = help fix this? I posted a hack workaround on the bug but don't know = enough Objective-C to guess at a correct fix. Does the new patch from Mitz fix the build for you? - Maciej >=20 > Thanks, >=20 > -Ken >=20 > =20 > > $ ./Tools/Scripts/build-webkit --release > build-log.txt > >=20 > > ... > >=20 > > In file included from = /Users/kbr/src/WebKit/WebKitBuild/Release/DerivedSources/WebKitLegacy/unif= ied-sources/UnifiedSource20-mm.mm:4: > > = /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:5= : error: use of undeclared identifier '_subviews'; did you mean = 'subviews'? > > _subviews =3D subviews; > > ^~~~~~~~~ > > subviews > > = /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:220:6= 3: note: 'subviews' declared here > > - (void)_setSubviewsIvar:(NSMutableArray<__kindof NSView *> = *)subviews { > > ^ > > = /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:1= 5: error: explicitly assigning value of variable of type = 'NSMutableArray<__kindof NSView *> *' to itself [-Werror,-Wself-assign] > > _subviews =3D subviews; > > ~~~~~~~~~ ^ ~~~~~~~~ > > = /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:228:3= 0: error: use of undeclared identifier '_subviews' > > return (NSMutableArray *)_subviews; > > ^ > > 3 errors generated. > >=20 > >=20 > >=20 > > Has anyone else run into this? > >=20 > > Thanks, > >=20 > > -Ken > >=20 > > _______________________________________________ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > https://lists.webkit.org/mailman/listinfo/webkit-dev = >=20 > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev --Apple-Mail=_A4D60106-6D35-4251-873C-7D531E15B3D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Oct 5, 2019, at 9:36 PM, Ken Russell <kbr@google.com> = wrote:

On Sat, Oct 5, 2019 = at 1:11 AM Tim Horton <timothy_horton@apple.com> wrote:

> On Oct 4, 2019, at 8:55 PM, Ken Russell <kbr@google.com> wrote:
>
> Hi,
>
> Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree = WebKit. With a clean WebKitBuild directory I'm seeing the following = build error:

What OS are you on?

You might want to peek at https://bugs.webkit.org/show_bug.cgi?id=3D199705

macOS 10.14.6, = Xcode 11.0 from the App Store.

Looks like the same problem. Could = anyone from Apple please try to help fix this? I posted a hack = workaround on the bug but don't know enough Objective-C to guess at a = correct fix.

Does the new patch from Mitz fix the build for = you?

- Maciej

Thanks,

-Ken

> $ ./Tools/Scripts/build-webkit --release > build-log.txt
>
> ...
>
> In file included from = /Users/kbr/src/WebKit/WebKitBuild/Release/DerivedSources/WebKitLegacy/unif= ied-sources/UnifiedSource20-mm.mm:4:
> = /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:5= : error: use of undeclared identifier '_subviews'; did you mean = 'subviews'?
> _subviews =3D subviews;
> ^~~~~~~~~
> subviews
> = /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:220:6= 3: note: 'subviews' declared here
> - (void)_setSubviewsIvar:(NSMutableArray<__kindof NSView *> = *)subviews {
> = = = ^
> = /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:1= 5: error: explicitly assigning value of variable of type = 'NSMutableArray<__kindof NSView *> *' to itself = [-Werror,-Wself-assign]
> _subviews =3D subviews;
> ~~~~~~~~~ ^ ~~~~~~~~
> = /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:228:3= 0: error: use of undeclared identifier '_subviews'
> return (NSMutableArray *)_subviews;
= > = ^
> 3 errors generated.
>
>
>
> Has anyone else run into this?
>
> Thanks,
>
> -Ken
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

_______________________________________________
webkit-dev = mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

= --Apple-Mail=_A4D60106-6D35-4251-873C-7D531E15B3D6-- --===============0963966880== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev --===============0963966880==--