'Re: Jigsaw Enhancement RFR round #2: 8159147 Add ClassLoader parameter to new ClassFileTransformer t'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: Jigsaw Enhancement RFR round #2: 8159147 Add ClassLoader parameter to new ClassFileTransformer t
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2016-07-05 16:38:11
Message-ID: 577BE273.3060708 () oracle ! com
[Download RAW message or body]

Thanks, Alan!
Serguei


On 7/5/16 08:42, Alan Bateman wrote:
>
>
>
> On 30/06/2016 07:57, serguei.spitsyn@oracle.com wrote:
>> Please, review the Jigsaw fix for the enhancement:
>> https://bugs.openjdk.java.net/browse/JDK-8159147
>>
>> Just a sanity check is needed.
>>
>> This update has fixes related to the Mandy's comments on the 
>> ClassFileTransformer.java:
>>   - one of the @implSpec statements is corrected
>>   - <code>null</code> has been replaced with {@code null}
>>
>>
>> Jdk webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8159147-Jigsaw-jli.jdk2/
>>
> This version looks good to me.
>
> -Alan


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Thanks, Alan!<br>
      Serguei<br>
      <br>
      <br>
      On 7/5/16 08:42, Alan Bateman wrote:<br>
    </div>
    <blockquote
      cite="mid:e3131b5f-a210-0863-6b68-c16c7347de16@oracle.com"
      type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      <p><br>
      </p>
      <br>
      <div class="moz-cite-prefix">On 30/06/2016 07:57, <a
          moz-do-not-send="true" class="moz-txt-link-abbreviated"
          href="mailto:serguei.spitsyn@oracle.com"><a \
class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a></a>  \
wrote:<br>  </div>
      <blockquote cite="mid:5774C2D8.9090105@oracle.com" type="cite">
        <meta http-equiv="content-type" content="text/html;
          charset=utf-8">
        Please, review the Jigsaw fix for the enhancement: <br>
           <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="https://bugs.openjdk.java.net/browse/JDK-8159147">https://bugs.openjdk.java.net/browse/JDK-8159147</a><br>
  <br>
        Just a sanity check is needed.<br>
        <br>
        This update has fixes related to the Mandy's comments on the <font
          size="-1"><font face="Lucida \
                Grande"><big>ClassFileTransformer.java:</big></font></font><br>
           - one of the @implSpec statements is corrected<br>
           - &lt;code&gt;null&lt;/code&gt; has been replaced with {@code
        null}<br>
        <br>
        <br>
        <font size="-1"><font face="Lucida Grande"><big>Jdk webrev:<br>
                 <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2016/jdk/8159147-Jigsaw-jli.jdk2/ \
">http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8159147-Jigsaw-jli.jdk2/</a><br>
  </big></font></font><font face="Helvetica, Arial,
          sans-serif"><br>
        </font></blockquote>
      <font face="Helvetica, Arial, sans-serif">This version looks good
        to me.<br>
        <br>
        -Alan</font><font size="-1"><font face="Lucida Grande"><br>
        </font></font> </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic