[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RFR: JDK-8145627 (sun.jvm.hotspot.oops.InstanceKlass::getSize() returns the incorrect size and has n
From: Jini George <jini.george () oracle ! com>
Date: 2016-07-05 16:24:17
Message-ID: 46c08ec5-8071-48ff-981d-0f6cb187e65d () default
[Download RAW message or body]
Hi all,
Please review the fix in Serviceability Agent (SA) for:
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8145627"JDK-8145627 \
(sun.jvm.hotspot.oops.InstanceKlass::getSize() returns the incorrect size and has no \
test)
The webrev is at:
http://cr.openjdk.java.net/~sballal/sponsorship/8145627/webrev.00/
The modifications include the fix and 2 tests to check the InstanceKlass sizes \
representing some well known classes and that of an interface. The tests compare the \
sizes returned by SA to those returned by jcmd. At this point, SA cannot view the \
InstanceKlasses representing anonymous classes. (This issue will be addressed in \
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8160228"JDK-8160228 (SA cannot \
view the LambdaMetaFactory generated anonymous instanceKlasses)). Hence the current \
fix does not include the size addition for InstanceKlasses representing anonymous \
classes.
Thanks,
- Jini Susan George
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:354188978;
mso-list-template-ids:-1741545776;}
@list l0:level1
{mso-level-tab-stop:.5in;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal>Hi all, <o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Please review the fix in \
Serviceability Agent (SA) for:<o:p></o:p></p><p class=MsoNormal><span lang=EN \
style='color:#333333'><a \
href="https://bugs.openjdk.java.net/browse/JDK-8145627">JDK-8145627</a></span><span \
lang=EN style='font-size:10.0pt;color:#333333'> </span><span lang=EN \
style='font-size:10.5pt;font-family:"Arial","sans-serif";color:#333333'>(</span>sun.jvm.hotspot.oops.InstanceKlass::getSize() \
returns the incorrect size and has no test)<o:p></o:p></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>The webrev is at: <o:p></o:p></span></p><p \
class=MsoNormal><span style='color:#1F497D'><a \
href="http://cr.openjdk.java.net/~sballal/sponsorship/8145627/webrev.00/">http://cr.openjdk.java.net/~sballal/sponsorship/8145627/webrev.00/</a> \
<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>The \
modifications include the fix and 2 tests to check the InstanceKlass sizes \
representing some well known classes and that of an interface. The tests \
compare the sizes returned by SA to those returned by jcmd. At this point, SA cannot \
view the <span lang=EN>InstanceKlasses representing anonymous classes. (This issue \
will be addressed in <a href="https://bugs.openjdk.java.net/browse/JDK-8160228" \
title="SA cannot view the LambdaMetaFactory generated anonymous \
instanceKlasses">JDK-8160228</a> (SA cannot view the LambdaMetaFactory generated \
anonymous instanceKlasses)). Hence the current fix does not include the size addition \
for InstanceKlasses representing anonymous classes.</span><o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Thanks,<o:p></o:p></p><p \
class=MsoNormal>- Jini Susan George<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic