[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2016-07-05 16:55:33
Message-ID: 577BE685.7010101 () oracle ! com
[Download RAW message or body]

On 7/5/16 06:11, Alan Bateman wrote:
> Just catching up on this thread, I assume this is the current patch:
>
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.6/ 
>
>
> For the description then it might be clearer to say "for a named 
> module" rather than "for a module" so that the first paragraph is 
> clear than this is function to obtain a reference to a named module.

Fixed.

>
> For the class_loader description then it might be clearer to say is 
> not NULL and a not a subclass of ...

Fixed.

>
> At some point then I assume the version="9.0.0" changes should be 
> collapsed into one change element.

Fixed.

>
> The rest looks okay to me.

Thanks, Alan!
Serguei

>
> -Alan
>
>

[prev in list] [next in list] [prev in thread] [next in thread]