[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v9]
From:       Thiago Milczarek Sayao <tsayao () openjdk ! org>
Date:       2023-05-28 20:53:27
Message-ID: jhZO1Q1JA6Fe_UnpZ3m1gRpcHlp89pWfZsyHcFtB4nw=.1076a320-76a4-48cd-9a98-133d85b5d771 () github ! com
[Download RAW message or body]

> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this \
> scroll event type, deltas are sent to java with the value equal to zero. 
> Here's whats happening:
> 
> We include all event masks, so when using gtk3 (>= 3.4.0) it includes \
> `GDK_SMOOTH_SCROLL_MASK` meaning we receive duplicated events, one with  `direction \
> = GDK_SMOOTH_SCROLL_MASK` and other with "legacy" direction (UP/DOWN). 
> When receiving the event corresponding to `GDK_SMOOTH_SCROLL_MASK` we ignored it \
> causing it to send deltas (x,y) = 0. 
> The fix now checks if `GDK_SMOOTH_SCROLL_MASK` is supported and uses it, also \
> adding smooth scroll functionality.

Thiago Milczarek Sayao has updated the pull request incrementally with one additional \
commit since the last revision:

  Listen only to smooth deltas

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1044/files
  - new: https://git.openjdk.org/jfx/pull/1044/files/dad897aa..176f5a50

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=08
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=07-08

  Stats: 25 lines in 1 file changed: 0 ins; 20 del; 5 mod
  Patch: https://git.openjdk.org/jfx/pull/1044.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1044/head:pull/1044

PR: https://git.openjdk.org/jfx/pull/1044


[prev in list] [next in list] [prev in thread] [next in thread]