[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8273379: GTK3 stops sending key events during drag and drop [v32]
From:       Thiago Milczarek Sayao <tsayao () openjdk ! org>
Date:       2023-05-28 21:10:11
Message-ID: PTz70VYScXL_AQJcgMYVHrMV94NjkdYfHHa8CLHKm6I=.79c59e05-7740-4ab8-afed-f79e1d9bf249 () github ! com
[Download RAW message or body]

On Sat, 27 May 2023 17:34:39 GMT, Martin Fox <duke@openjdk.org> wrote:

> I don't think the original bug should be fixed as written. On both Mac and Windows \
> the platform drag-and-drop system consumes all key events (well, on the Mac we see \
> some `keyUp:` events but not for modifiers). That's a good thing, it prevents the \
> user from invoking shortcuts that might close the app or source window. I don't see \
> why Linux should be any different. It would be very odd for a UI toolkit to allow \
> key events through during drag-and-drop and even odder if that only happened on one \
> platform. 
> Whoever reported that bug has a problem they're trying to solve but I think they \
> proposed the wrong solution.

Now that you said, I agree. 

There are some fragile parts that I replaced in this PR, that could be causing some \
bugs as [8280383](https://bugs.openjdk.org/browse/JDK-8280383). I could rework it so \
it has less changes.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/986#issuecomment-1566263876


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic