[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8091153: Customize the Table Button Menu
From:       Marius Hanl <mhanl () openjdk ! org>
Date:       2023-05-28 11:50:59
Message-ID: lNnn_halA02FOQzPS8f9vua9BulEltBWPq4yjdZ-HAs=.8697f31c-b0ba-48bb-b83e-d775dd635130 () github ! com
[Download RAW message or body]

On Sat, 13 May 2023 19:11:26 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> This PR implements a way to override the table column menu. 
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu` method. \
> This new method is protected and therefore can be overidden by developers. If not \
> overridden, the known default column 'ContextMenu' is created and shown. 
> This PR also resolves [JDK-8091419 ](https://bugs.openjdk.org/browse/JDK-8091419) \
> (The method `showColumnMenu` can be overridden and made public now) 
> This PR also helps with [JDK-8092148](https://bugs.openjdk.org/browse/JDK-8092148), \
> but does not address all the points mentioned in the ticket.  Now that everyone can \
> provide their own implementation, we can think of treating the current \
> implementation of the table column menu as an \
> [MVP](https://en.wikipedia.org/wiki/Minimum_viable_product) and any other requested \
> feature/idea should be fulfilled by providing your own implementaion of the menu.

This pull request has now been integrated.

Changeset: 56fb71af
Author:    Marius Hanl <mhanl@openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/56fb71af830a78c5b950fd1aaa2779f51ab4007b
                
Stats:     124 lines in 3 files changed: 110 ins; 12 del; 2 mod

8091153: Customize the Table Button Menu
8091419: TableView: invoke table menu button programmatically

Reviewed-by: kcr, angorya

-------------

PR: https://git.openjdk.org/jfx/pull/1135


[prev in list] [next in list] [prev in thread] [next in thread]