[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: [Nepomuk] Re: Review Request: Setup for integration tests in
From: Paweł_Paprota <ppawel () fastmail ! fm>
Date: 2011-07-06 18:44:35
Message-ID: 20110706184435.3289.42066 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 4, 2011, 8:48 a.m., Vishesh Handa wrote:
> > nepomuk/tests/indexertests.cpp, line 77
> > <http://git.reviewboard.kde.org/r/101790/diff/2/?file=25645#file25645line77>
> >
> > Does this test pass? Cause from what I remember, it shouldn't pass.
>
> Paweł Paprota wrote:
> Yes it does, why wouldn't it?
Actually, when I rebased integration-tests branch to the master - it doesn't pass \
anymore... same for several tests in the storage service. I think there is a \
regression in the indexer/storage, now I get the following message for each file that \
is processed by Strigi service:
Nepomuk::DataManagementModel::storeResources: Last Error: "Invalid argument (1)": \
"<http://www.semanticdesktop.org/ontologies/2007/01/19/nie#isPartOf> has a rdfs:range \
of <http://www.semanticdesktop.org/ontologies/2007/01/19/nie#InformationElement>. \
<file:///home/ppawel/kdesrc/build/kde-runtime/nepomuk/tests/testdata> only has the \
following types <http://www.w3.org/2000/01/rdf-schema#Resource>"
> On July 4, 2011, 8:48 a.m., Vishesh Handa wrote:
> > nepomuk/CMakeLists.txt, line 10
> > <http://git.reviewboard.kde.org/r/101790/diff/2/?file=25636#file25636line10>
> >
> > I don't think contaminating the global CMakeLists.txt is a good idea. Whatever \
> > includes are required should be in the local CMakeLists.txt
>
> Paweł Paprota wrote:
> IIRC, those includes are needed for various different source folders, that's why I \
> moved it to the root. In general include paths are a mess. I will revisit this and \
> try to move them to more specific places...
> Sebastian Trueg wrote:
> Please try to refrain from using expressions like "are a mess" when talking about \
> work others have done.
Sorry it was not necessary, it was just a frustration talking after fighting the \
build system... I do appreciate the work that has been done on this project.
> On July 4, 2011, 8:48 a.m., Vishesh Handa wrote:
> > nepomuk/services/strigi/nepomukindexer.h, line 50
> > <http://git.reviewboard.kde.org/r/101790/diff/2/?file=25638#file25638line50>
> >
> > I've would prefer something like IndexingJob, which makes it obvious it is an \
> > asynchronous process implemented via KJob.
>
> Paweł Paprota wrote:
> I think more important is that it launches nepomukindexer binary using KProcess but \
> if you insist I can change it.
> Sebastian Trueg wrote:
> Actually it launching the indexer process is an implementation detail. Thus, it is \
> bad design to put that into the name of the class. Vishesh is correct in suggesting \
> a name like IndexingJob.
I'd say it is a rather large "detail" but this is only naming so I will do as you \
want.
- Paweł
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101790/#review4368
-----------------------------------------------------------
On June 28, 2011, 7:31 a.m., Paweł Paprota wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101790/
> -----------------------------------------------------------
>
> (Updated June 28, 2011, 7:31 a.m.)
>
>
> Review request for Nepomuk.
>
>
> Summary
> -------
>
> This is a little ground work for writing integration tests in order to test Nepomuk \
> components in the "real" setup - with D-Bus/socket communication, Virtuoso \
> repository, KConfig configuration running etc.
> Also included are simple tests for indexing of files (see indexertests.cpp).
>
> See README for details.
>
> The code is also available here:
>
> https://github.com/ppawel/kde-runtime/tree/integration-tests
>
>
> Diffs
> -----
>
> nepomuk/CMakeLists.txt c6a1879
> nepomuk/services/strigi/indexscheduler.cpp 56914a7
> nepomuk/services/strigi/nepomukindexer.h 08abb2a
> nepomuk/services/strigi/nepomukindexer.cpp d796983
> nepomuk/services/strigi/strigiservice.h 2eb7eac
> nepomuk/services/strigi/strigiservice.cpp 0189679
> nepomuk/tests/CMakeLists.txt PRE-CREATION
> nepomuk/tests/README PRE-CREATION
> nepomuk/tests/indexertests.h PRE-CREATION
> nepomuk/tests/indexertests.cpp PRE-CREATION
> nepomuk/tests/lib/CMakeLists.txt PRE-CREATION
> nepomuk/tests/lib/NepomukTestLibMacros.cmake PRE-CREATION
> nepomuk/tests/lib/nepomuk-repository-with-ontologies.tgz PRE-CREATION
> nepomuk/tests/lib/nepomukserverrc.in PRE-CREATION
> nepomuk/tests/lib/nepomuktest_export.h PRE-CREATION
> nepomuk/tests/lib/testbase.h PRE-CREATION
> nepomuk/tests/lib/testbase.cpp PRE-CREATION
> nepomuk/tests/runNepomukTest.sh PRE-CREATION
> nepomuk/tests/test/CMakeLists.txt PRE-CREATION
> nepomuk/tests/test/filewatch/CMakeLists.txt PRE-CREATION
> nepomuk/tests/test/filewatch/filewatch.h PRE-CREATION
> nepomuk/tests/test/filewatch/filewatch.cpp PRE-CREATION
> nepomuk/tests/test/identificationtest.h PRE-CREATION
> nepomuk/tests/test/identificationtest.cpp PRE-CREATION
> nepomuk/tests/testdata/CMakeLists.txt PRE-CREATION
> nepomuk/tests/testdata/klogo.png PRE-CREATION
> nepomuk/tests/testdata/trollface.jpg PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/101790/diff
>
>
> Testing
> -------
>
> Tests should execute with simple "make test". I did however have some problems \
> (segfaults) with sendEvents method that notifies the user that "indexing started \
> for fast search" - I had to disable it locally, I will try to track down the cause \
> of this if it is reproducible.
>
> Thanks,
>
> Paweł
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101790/">http://git.reviewboard.kde.org/r/101790/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 4th, 2011, 8:48 a.m., <b>Vishesh Handa</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25636#file25636line10" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">10</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
${nepomuk_SOURCE_DIR}/services/storage/lib</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think \
contaminating the global CMakeLists.txt is a good idea. Whatever includes are \
required should be in the local CMakeLists.txt</pre> </blockquote>
<p>On July 5th, 2011, 10:42 a.m., <b>Paweł Paprota</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">IIRC, those includes are \
needed for various different source folders, that's why I moved it to the root. \
In general include paths are a mess. I will revisit this and try to move them to more \
specific places...</pre> </blockquote>
<p>On July 6th, 2011, 8:38 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please try to refrain \
from using expressions like "are a mess" when talking about work others \
have done.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry it \
was not necessary, it was just a frustration talking after fighting the build \
system... I do appreciate the work that has been done on this project.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 4th, 2011, 8:48 a.m., <b>Vishesh Handa</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25638#file25638line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/services/strigi/nepomukindexer.h</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace Nepomuk {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">50</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">class</span> <span class="n">Indexer</span> <span class="o">:</span> <span \
class="n">public</span> <span class="n">KJob</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">50</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">class</span> <span class="n">Indexer<span class="hl">Launcher</span></span> \
<span class="o">:</span> <span class="n">public</span> <span \
class="n">KJob</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've would prefer \
something like IndexingJob, which makes it obvious it is an asynchronous process \
implemented via KJob.</pre> </blockquote>
<p>On July 5th, 2011, 10:46 a.m., <b>Paweł Paprota</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think more important \
is that it launches nepomukindexer binary using KProcess but if you insist I can \
change it.</pre> </blockquote>
<p>On July 6th, 2011, 8:38 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually it launching \
the indexer process is an implementation detail. Thus, it is bad design to put that \
into the name of the class. Vishesh is correct in suggesting a name like \
IndexingJob.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd say \
it is a rather large "detail" but this is only naming so I will do as you \
want.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 4th, 2011, 8:48 a.m., <b>Vishesh Handa</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25645#file25645line77" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/indexertests.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void IndexerTests::testIndexedProperties() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">77</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">IndexerTests</span><span \
class="o">::</span><span class="n">testDirectoryIndexing</span><span \
class="p">()</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does this test pass? \
Cause from what I remember, it shouldn't pass.</pre> </blockquote>
<p>On July 5th, 2011, 10:40 a.m., <b>Paweł Paprota</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes it does, why \
wouldn't it?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, \
when I rebased integration-tests branch to the master - it doesn't pass \
anymore... same for several tests in the storage service. I think there is a \
regression in the indexer/storage, now I get the following message for each file that \
is processed by Strigi service:
Nepomuk::DataManagementModel::storeResources: Last Error: "Invalid argument \
(1)": "<http://www.semanticdesktop.org/ontologies/2007/01/19/nie#isPartOf> \
has a rdfs:range of <http://www.semanticdesktop.org/ontologies/2007/01/19/nie#InformationElement>. \
<file:///home/ppawel/kdesrc/build/kde-runtime/nepomuk/tests/testdata> only has \
the following types <http://www.w3.org/2000/01/rdf-schema#Resource>"</pre> \
<br />
<p>- Paweł</p>
<br />
<p>On June 28th, 2011, 7:31 a.m., Paweł Paprota wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Paweł Paprota.</div>
<p style="color: grey;"><i>Updated June 28, 2011, 7:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a little ground work for writing integration tests in order to \
test Nepomuk components in the "real" setup - with D-Bus/socket \
communication, Virtuoso repository, KConfig configuration running etc.
Also included are simple tests for indexing of files (see indexertests.cpp).
See README for details.
The code is also available here:
https://github.com/ppawel/kde-runtime/tree/integration-tests</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests should execute with simple "make test". I did however \
have some problems (segfaults) with sendEvents method that notifies the user that \
"indexing started for fast search" - I had to disable it locally, I will \
try to track down the cause of this if it is reproducible.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/CMakeLists.txt <span style="color: grey">(c6a1879)</span></li>
<li>nepomuk/services/strigi/indexscheduler.cpp <span style="color: \
grey">(56914a7)</span></li>
<li>nepomuk/services/strigi/nepomukindexer.h <span style="color: \
grey">(08abb2a)</span></li>
<li>nepomuk/services/strigi/nepomukindexer.cpp <span style="color: \
grey">(d796983)</span></li>
<li>nepomuk/services/strigi/strigiservice.h <span style="color: \
grey">(2eb7eac)</span></li>
<li>nepomuk/services/strigi/strigiservice.cpp <span style="color: \
grey">(0189679)</span></li>
<li>nepomuk/tests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/indexertests.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/indexertests.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/lib/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/lib/NepomukTestLibMacros.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/lib/nepomuk-repository-with-ontologies.tgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/lib/nepomukserverrc.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/lib/nepomuktest_export.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/lib/testbase.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/lib/testbase.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/runNepomukTest.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/test/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/test/filewatch/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/test/filewatch/filewatch.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/test/filewatch/filewatch.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/test/identificationtest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/test/identificationtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/testdata/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/testdata/klogo.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>nepomuk/tests/testdata/trollface.jpg <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101790/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic