This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101790/

On July 4th, 2011, 8:48 a.m., Vishesh Handa= wrote:

= = =

nepomuk/CMakeLists.txt (Diff revision 2)

		10	${nepomuk_SOURCE_DIR}/services/storage/lib

I don'=
;t think contaminating the global CMakeLists.txt is a good idea. Whatever i=
ncludes are required should be in the local CMakeLists.txt

On July 5th, 2011, 10:42 a.m., Pawe=C5=82 Paprota wrote:

IIRC, tho=
se includes are needed for various different source folders, that's why=
 I moved it to the root. In general include paths are a mess. I will revisi=
t this and try to move them to more specific places...

On July 6th, 2011, 8:38 a.m., Sebastian Trueg wrote:

Please tr=
y to refrain from using expressions like "are a mess" when talkin=
g about work others have done.

Sorry it was not necessary, it was just a frustration talking after =
fighting the build system... I do appreciate the work that has been done on=
 this project.

On July 4th, 2011, 8:48 a.m., Vishesh Handa= wrote:

= = =

nepomuk/services/strigi/nepomukindexer.h (Diff revision 2)
namespace Nepomuk {
50	class Indexer : public KJob	50	class IndexerLauncher := public KJob =

I've =
would prefer something like IndexingJob, which makes it obvious it is an as=
ynchronous process implemented via KJob.

On July 5th, 2011, 10:46 a.m., Pawe=C5=82 Paprota wrote:

I think m=
ore important is that it launches nepomukindexer binary using KProcess but =
if you insist I can change it.

On July 6th, 2011, 8:38 a.m., Sebastian Trueg wrote:

Actually =
it launching the indexer process is an implementation detail. Thus, it is b=
ad design to put that into the name of the class. Vishesh is correct in sug=
gesting a name like IndexingJob.

I'd say it is a rather large "detail" but this is only=
 naming so I will do as you want.

On July 4th, 2011, 8:48 a.m., Vishesh Handa= wrote:
= = =
nepomuk/tests/indexertests.cpp (Diff revision 2)
void IndexerTests::testIndexedProperties() {
77
void IndexerTests::testDire=
ctoryIndexing() {<=
/pre>
Does this=
 test pass? Cause from what I remember, it shouldn't pass.
On July 5th, 2011, 10:40 a.m., Pawe=C5=82 Paprota wrote:
Yes it do=
es, why wouldn't it?

nepomuk/tests/indexertests.cpp (Diff revision 2)
	void IndexerTests::testIndexedProperties() {
		77	void IndexerTests::testDire= ctoryIndexing() {<= /pre>

Actually, when I rebased integration-tests branch to the master - it=
 doesn't pass anymore... same for several tests in the storage service.=
 I think there is a regression in the indexer/storage, now I get the follow=
ing message for each file that is processed by Strigi service:

Nepomuk::DataManagementModel::storeResources: Last Error:  "Invalid ar=
gument (1)": "<http://www.semanticdesktop.org/ontologies/2007/=
01/19/nie#isPartOf> has a rdfs:range of <http://www.semanticdesktop.o=
rg/ontologies/2007/01/19/nie#InformationElement>. <file:///home/ppawe=
l/kdesrc/build/kde-runtime/nepomuk/tests/testdata> only has the followin=
g types <http://www.w3.org/2000/01/rdf-schema#Resource>"

- Pawe=C5=82

On June 28th, 2011, 7:31 a.m., Pawe=C5=82 Paprota wrote:

Review request for Nepomuk.

By Pawe=C5=82 Paprota.

Updated June 28, 2011, 7:31 a.m.

Descripti= on

This is a little ground work for writing integration tests i=
n order to test Nepomuk components in the "real" setup - with D-B=
us/socket communication, Virtuoso repository, KConfig configuration running=
 etc.

Also included are simple tests for indexing of files (see indexertests.cpp).

See README for details.

The code is also available here:

https://github.com/ppawel/kde-runtime/tree/integration-tests

Testing <= /h1>

Tests should execute with simple "make test". I di=
d however have some problems (segfaults) with sendEvents method that notifi=
es the user that "indexing started for fast search" - I had to di=
sable it locally, I will try to track down the cause of this if it is repro=
ducible.

Diffs=

nepomuk/CMakeLists.txt (c6a1879)
nepomuk/services/strigi/indexscheduler.cpp (56914a7)
nepomuk/services/strigi/nepomukindexer.h (= 08abb2a)
nepomuk/services/strigi/nepomukindexer.cpp (d796983)
nepomuk/services/strigi/strigiservice.h (2= eb7eac)
nepomuk/services/strigi/strigiservice.cpp = (0189679)
nepomuk/tests/CMakeLists.txt (PRE-CREATION= )
nepomuk/tests/README (PRE-CREATION)=
nepomuk/tests/indexertests.h (PRE-CREATION= )
nepomuk/tests/indexertests.cpp (PRE-CREATI= ON)
nepomuk/tests/lib/CMakeLists.txt (PRE-CREA= TION)
nepomuk/tests/lib/NepomukTestLibMacros.cmake (PRE-CREATION)
nepomuk/tests/lib/nepomuk-repository-with-ontologies.tgz (PRE-CREATION)
nepomuk/tests/lib/nepomukserverrc.in (PRE-= CREATION)
nepomuk/tests/lib/nepomuktest_export.h (PR= E-CREATION)
nepomuk/tests/lib/testbase.h (PRE-CREATION= )
nepomuk/tests/lib/testbase.cpp (PRE-CREATI= ON)
nepomuk/tests/runNepomukTest.sh (PRE-CREAT= ION)
nepomuk/tests/test/CMakeLists.txt (PRE-CRE= ATION)
nepomuk/tests/test/filewatch/CMakeLists.txt (= PRE-CREATION)
nepomuk/tests/test/filewatch/filewatch.cpp (PRE-CREATION)
nepomuk/tests/test/identificationtest.h (P= RE-CREATION)
nepomuk/tests/test/identificationtest.cpp = (PRE-CREATION)
nepomuk/tests/testdata/CMakeLists.txt (PRE= -CREATION)
nepomuk/tests/testdata/klogo.png (PRE-CREA= TION)
nepomuk/tests/testdata/trollface.jpg (PRE-= CREATION)

View Diff

Descripti= on

Testing <= /h1> Tests should execute with simple "make test". I di= d however have some problems (segfaults) with sendEvents method that notifi= es the user that "indexing started for fast search" - I had to di= sable it locally, I will try to track down the cause of this if it is repro= ducible.

Diffs=

Testing <= /h1>

Tests should execute with simple "make test". I di= d however have some problems (segfaults) with sendEvents method that notifi= es the user that "indexing started for fast search" - I had to di= sable it locally, I will try to track down the cause of this if it is repro= ducible.