'[Nepomuk] Re: Review Request: Setup for integration tests in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    [Nepomuk] Re: Review Request: Setup for integration tests in
From:       "Sebastian Trueg" <sebastian () trueg ! de>
Date:       2011-07-06 9:00:44
Message-ID: 20110706090044.853.89083 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101790/#review4437
-----------------------------------------------------------

nepomuk/services/strigi/strigiservice.h
<http://git.reviewboard.kde.org/r/101790/#comment3726>

    I would prefer a method which is also exposed via DBus. This makes sens=
e in any case. I would often like to change the indexing speed for manual t=
esting for example.
    =

    But for that I would not use the IndexScheduler enum but an int which d=
irectly expresses the delay between files.
    =

    Then we could even change the enum to have msec values or even replace =
it by static const ints.

nepomuk/tests/indexertests.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3727>

    Please follow the code indentation policy in KDE. Methods do not use tr=
ailing brackets.

nepomuk/tests/indexertests.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3728>

    KConfig objects are typically created on the stack. The only "advantage=
" of this approach is a nice memory leak. ;)

nepomuk/tests/indexertests.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3732>

    Is QDir::currentPath() really appropriate? The test could be started fr=
om anywhere? How about a cmale config files which puts the actual path to t=
he test data into the source file?

nepomuk/tests/indexertests.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3729>

    "NULL" is a C definition. Please use "0" instead.

nepomuk/tests/indexertests.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3730>

    Superfluous variable.

nepomuk/tests/indexertests.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3731>

    #include "indexertests.moc"
    =

    This is just policy and slightly improves compilation performance since=
 the moc file does not have to be compiled independently.

nepomuk/tests/lib/nepomukserverrc.in
<http://git.reviewboard.kde.org/r/101790/#comment3733>

    Hm, how about we add a command line parameter to nepomukserver which sp=
ecifies which services to start. Otherwise new services not mentioned in th=
is list will be started.

nepomuk/tests/lib/testbase.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3734>

    This is never deleted.

nepomuk/tests/lib/testbase.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3735>

    See comment about the nepomukserver parameter. Once we have that there =
is no need to stop services here.

nepomuk/tests/lib/testbase.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3736>

    This is IMHO unclean. It would be best to simply stop Virtuoso, recreat=
e the DB from the tar and restart Virtuoso.
    =

    The removeAllStatements is not really public API anyway anymore and the=
 storage service does create some information we might miss here.
    =

    This, however, has a low priority for me. :)

nepomuk/tests/test/filewatch/filewatch.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3738>

    KIO can do that for you.

nepomuk/tests/test/filewatch/filewatch.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3737>

    Tabs are evil. :P

nepomuk/tests/test/filewatch/filewatch.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3739>

    Again KIO can do this.

nepomuk/tests/test/filewatch/filewatch.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3741>

    This is very ugly. How about we add a signal to the filewatcher DBus in=
terface which is emitted once the filewatcher has handled its queue.

nepomuk/tests/test/filewatch/filewatch.cpp
<http://git.reviewboard.kde.org/r/101790/#comment3740>

    Use KTempDir instead.

- Sebastian

On June 28, 2011, 7:31 a.m., Pawe=C5=82 Paprota wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101790/
> -----------------------------------------------------------
> =

> (Updated June 28, 2011, 7:31 a.m.)
> =

> =

> Review request for Nepomuk.
> =

> =

> Summary
> -------
> =

> This is a little ground work for writing integration tests in order to te=
st Nepomuk components in the "real" setup - with D-Bus/socket communication=
, Virtuoso repository, KConfig configuration running etc.
> =

> Also included are simple tests for indexing of files (see indexertests.cp=
p).
> =

> See README for details.
> =

> The code is also available here:
> =

> https://github.com/ppawel/kde-runtime/tree/integration-tests
> =

> =

> Diffs
> -----
> =

>   nepomuk/CMakeLists.txt c6a1879 =

>   nepomuk/services/strigi/indexscheduler.cpp 56914a7 =

>   nepomuk/services/strigi/nepomukindexer.h 08abb2a =

>   nepomuk/services/strigi/nepomukindexer.cpp d796983 =

>   nepomuk/services/strigi/strigiservice.h 2eb7eac =

>   nepomuk/services/strigi/strigiservice.cpp 0189679 =

>   nepomuk/tests/CMakeLists.txt PRE-CREATION =

>   nepomuk/tests/README PRE-CREATION =

>   nepomuk/tests/indexertests.h PRE-CREATION =

>   nepomuk/tests/indexertests.cpp PRE-CREATION =

>   nepomuk/tests/lib/CMakeLists.txt PRE-CREATION =

>   nepomuk/tests/lib/NepomukTestLibMacros.cmake PRE-CREATION =

>   nepomuk/tests/lib/nepomuk-repository-with-ontologies.tgz PRE-CREATION =

>   nepomuk/tests/lib/nepomukserverrc.in PRE-CREATION =

>   nepomuk/tests/lib/nepomuktest_export.h PRE-CREATION =

>   nepomuk/tests/lib/testbase.h PRE-CREATION =

>   nepomuk/tests/lib/testbase.cpp PRE-CREATION =

>   nepomuk/tests/runNepomukTest.sh PRE-CREATION =

>   nepomuk/tests/test/CMakeLists.txt PRE-CREATION =

>   nepomuk/tests/test/filewatch/CMakeLists.txt PRE-CREATION =

>   nepomuk/tests/test/filewatch/filewatch.h PRE-CREATION =

>   nepomuk/tests/test/filewatch/filewatch.cpp PRE-CREATION =

>   nepomuk/tests/test/identificationtest.h PRE-CREATION =

>   nepomuk/tests/test/identificationtest.cpp PRE-CREATION =

>   nepomuk/tests/testdata/CMakeLists.txt PRE-CREATION =

>   nepomuk/tests/testdata/klogo.png PRE-CREATION =

>   nepomuk/tests/testdata/trollface.jpg PRE-CREATION =

> =

> Diff: http://git.reviewboard.kde.org/r/101790/diff
> =

> =

> Testing
> -------
> =

> Tests should execute with simple "make test". I did however have some pro=
blems (segfaults) with sendEvents method that notifies the user that "index=
ing started for fast search" - I had to disable it locally, I will try to t=
rack down the cause of this if it is reproducible.
> =

> =

> Thanks,
> =

> Pawe=C5=82
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101790/">http://git.reviewboard.kde.org/r/101790/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25640#file25640line47" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/services/strigi/strigiservice.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">45</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew">        	</span>	<span class="n">IndexScheduler</span><span \
class="o">::</span><span class="n">IndexingSpeed</span> <span class="n">speed</span> \
<span class="o">=</span> <span class="n">IndexScheduler</span><span \
class="o">::</span><span class="n">SnailPace</span> <span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would \
prefer a method which is also exposed via DBus. This makes sense in any case. I would \
often like to change the indexing speed for manual testing for example.

But for that I would not use the IndexScheduler enum but an int which directly \
expresses the delay between files.

Then we could even change the enum to have msec values or even replace it by static \
const ints.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25645#file25645line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/indexertests.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">using namespace Nepomuk;</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">IndexerTests</span><span \
class="o">::</span><span class="n">testSimpleIndexing</span><span class="p">()</span> \
<span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
follow the code indentation policy in KDE. Methods do not use trailing \
brackets.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25645#file25645line82" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/indexertests.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">using namespace Nepomuk;</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">82</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">	<span \
class="n">KConfig</span><span class="o">*</span> <span class="n">config</span> <span \
class="o">=</span> <span class="k">new</span> <span class="n">KConfig</span><span \
class="p">(</span><span class="s">&quot;nepomukstrigirc&quot;</span> <span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KConfig \
objects are typically created on the stack. The only &quot;advantage&quot; of this \
approach is a nice memory leak. ;)</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25645#file25645line84" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/indexertests.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">using namespace Nepomuk;</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">84</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">	<span \
class="n">config</span><span class="o">-&gt;</span><span class="n">group</span><span \
class="p">(</span><span class="s">&quot;General&quot;</span><span \
class="p">).</span><span class="n">writePathEntry</span><span class="p">(</span><span \
class="s">&quot;folders&quot;</span><span class="p">,</span> <span \
class="n">QDir</span><span class="o">::</span><span class="n">currentPath</span><span \
class="p">().</span><span class="n">append</span><span class="p">(</span><span \
class="s">&quot;/testdata&quot;</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is \
QDir::currentPath() really appropriate? The test could be started from anywhere? How \
about a cmale config files which puts the actual path to the test data into the \
source file?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25645#file25645line87" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/indexertests.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">using namespace Nepomuk;</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">87</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">	<span \
class="n">Nepomuk</span><span class="o">::</span><span class="n">StrigiService</span> \
<span class="n">s</span><span class="p">(</span><span class="nb">NULL</span><span \
class="p">,</span> <span class="n">QList</span><span class="o">&lt;</span><span \
class="n">QVariant</span><span class="o">&gt;</span><span class="p">(),</span> <span \
class="n">IndexScheduler</span><span class="o">::</span><span \
class="n">FullSpeed</span><span class="p">);</span> <span class="c1">// This should \
start the strigi service and index scheduler.</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">&quot;NULL&quot; is a C definition. Please use &quot;0&quot; \
instead.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25645#file25645line89" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/indexertests.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">using namespace Nepomuk;</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">89</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">	<span \
class="kt">bool</span> <span class="n">gotSignal</span> <span class="o">=</span> \
<span class="n">QTest</span><span class="o">::</span><span \
class="n">kWaitForSignal</span><span class="p">(</span><span \
class="o">&amp;</span><span class="n">s</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">indexingStopped</span><span class="p">()),</span> <span \
class="mi">15000</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Superfluous \
variable.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25645#file25645line110" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/indexertests.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">using namespace Nepomuk;</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">110</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">QTEST_KDEMAIN</span><span class="p">(</span><span \
class="n">IndexerTests</span><span class="p">,</span> <span \
class="n">NoGUI</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">#include \
&quot;indexertests.moc&quot;

This is just policy and slightly improves compilation performance since the moc file \
does not have to be compiled independently.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25649#file25649line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/lib/nepomukserverrc.in</a>  <span style="font-weight: \
normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">[Basic \
Settings]</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, how \
about we add a command line parameter to nepomukserver which specifies which services \
to start. Otherwise new services not mentioned in this list will be started.</pre> \
</div> <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25652#file25652line53" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/lib/testbase.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">Nepomuk::TestBase::TestBase(QObject* parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">d</span><span class="o">-&gt;</span><span class="n">m_serviceManager</span> \
<span class="o">=</span> <span class="k">new</span> <span class="n">org</span><span \
class="o">::</span><span class="n">kde</span><span class="o">::</span><span \
class="n">nepomuk</span><span class="o">::</span><span \
class="n">ServiceManager</span><span class="p">(</span> <span \
class="s">&quot;org.kde.NepomukServer&quot;</span><span class="p">,</span> <span \
class="s">&quot;/servicemanager&quot;</span><span class="p">,</span> <span \
class="n">QDBusConnection</span><span class="o">::</span><span \
class="n">sessionBus</span><span class="p">()</span> <span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is \
never deleted.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25652#file25652line64" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/lib/testbase.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">Nepomuk::TestBase::TestBase(QObject* parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">64</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">Q_FOREACH</span><span class="p">(</span> <span class="k">const</span> <span \
class="n">QString</span> <span class="o">&amp;</span> <span \
class="n">service</span><span class="p">,</span> <span class="n">services</span> \
<span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See comment \
about the nepomukserver parameter. Once we have that there is no need to stop \
services here.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25652#file25652line84" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/lib/testbase.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">Nepomuk::TestBase::TestBase(QObject* parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">84</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is \
IMHO unclean. It would be best to simply stop Virtuoso, recreate the DB from the tar \
and restart Virtuoso.

The removeAllStatements is not really public API anyway anymore and the storage \
service does create some information we might miss here.

This, however, has a low priority for me. :)</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25657#file25657line51" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/test/filewatch/filewatch.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">namespace {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="c1">// It&#39;s hard to believe that Qt doesn&#39;t provide its own copy \
folder function</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KIO can do \
that for you.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25657#file25657line54" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/test/filewatch/filewatch.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">namespace {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">54</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew">        </span></pre></td>  </tr>

 </tbody>

</table>

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25657#file25657line84" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/test/filewatch/filewatch.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">namespace {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">84</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">bool</span> <span class="n">removeDir</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">dirName</span><span \
class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Again KIO \
can do this.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25657#file25657line134" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/test/filewatch/filewatch.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">namespace {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">134</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QTest</span><span class="o">::</span><span class="n">qSleep</span><span \
class="p">(</span> <span class="mi">4000</span> <span class="p">);</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is \
very ugly. How about we add a signal to the filewatcher DBus interface which is \
emitted once the filewatcher has handled its queue.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101790/diff/2/?file=25657#file25657line176" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/tests/test/filewatch/filewatch.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">namespace {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">176</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">QString</span> <span class="n">FileWatchTest</span><span \
class="o">::</span><span class="n">createTempDir</span><span \
class="p">()</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use \
KTempDir instead.</pre> </div>
<br />

<p>- Sebastian</p>

<br />
<p>On June 28th, 2011, 7:31 a.m., Paweł Paprota wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk.</div>
<div>By Paweł Paprota.</div>

<p style="color: grey;"><i>Updated June 28, 2011, 7:31 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a little ground work for writing integration tests in order to \
test Nepomuk components in the &quot;real&quot; setup - with D-Bus/socket \
communication, Virtuoso repository, KConfig configuration running etc.

Also included are simple tests for indexing of files (see indexertests.cpp).

See README for details.

The code is also available here:

https://github.com/ppawel/kde-runtime/tree/integration-tests</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests should execute with simple &quot;make test&quot;. I did however \
have some problems (segfaults) with sendEvents method that notifies the user that \
&quot;indexing started for fast search&quot; - I had to disable it locally, I will \
try to track down the cause of this if it is reproducible.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>nepomuk/CMakeLists.txt <span style="color: grey">(c6a1879)</span></li>

 <li>nepomuk/services/strigi/indexscheduler.cpp <span style="color: \
grey">(56914a7)</span></li>

 <li>nepomuk/services/strigi/nepomukindexer.h <span style="color: \
grey">(08abb2a)</span></li>

 <li>nepomuk/services/strigi/nepomukindexer.cpp <span style="color: \
grey">(d796983)</span></li>

 <li>nepomuk/services/strigi/strigiservice.h <span style="color: \
grey">(2eb7eac)</span></li>

 <li>nepomuk/services/strigi/strigiservice.cpp <span style="color: \
grey">(0189679)</span></li>

 <li>nepomuk/tests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/README <span style="color: grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/indexertests.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/indexertests.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/lib/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/lib/NepomukTestLibMacros.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/lib/nepomuk-repository-with-ontologies.tgz <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/lib/nepomukserverrc.in <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/lib/nepomuktest_export.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/lib/testbase.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/lib/testbase.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/runNepomukTest.sh <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/test/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/test/filewatch/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/test/filewatch/filewatch.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/test/filewatch/filewatch.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/test/identificationtest.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/test/identificationtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/testdata/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/testdata/klogo.png <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>nepomuk/tests/testdata/trollface.jpg <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101790/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 