[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: CMake style
From:       Alex Turbov <i.zaufi () gmail ! com>
Date:       2019-07-24 9:23:04
Message-ID: CANktQtv7jv97EbpUgAMp4Ve10rsuoQ+OdMjeQgv04bUmPhMBcg () mail ! gmail ! com
[Download RAW message or body]

Hi,

On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer <daan.j.demeyer@gmail.com>
wrote:

> The KATE_VERSION variable was used in some source files but by passing the
> version as a command line define via CMake allowed me to remove the
> config.h file completely.
>

 The good practice IMO is completely opposite: move `#defines` from CLI to
generated `*.h` file(s) as much as you can. As for me, it'll make the CLI
shorter and readable by humans w/ less pain. But the main reason: various
shells have different limitations on CI length...

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr">Hi,<br></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer &lt;<a \
href="mailto:daan.j.demeyer@gmail.com">daan.j.demeyer@gmail.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="ltr"><div>The KATE_VERSION variable was used in some source files but by passing \
the version as a command line define via CMake allowed me to remove the config.h file \
completely.</div></div></blockquote><div><br></div><div>  The good practice IMO is \
completely opposite: move `#defines` from CLI to generated `*.h` file(s) as much as \
you can. As for me, it&#39;ll make the CLI shorter and readable by humans w/ less \
pain. But the main reason: various shells have different limitations on CI \
length...</div><div><br></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]