[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: CMake style
From:       Daan De Meyer <daan.j.demeyer () gmail ! com>
Date:       2019-07-24 10:43:03
Message-ID: CAO8sHckPj0VY+5=oue86=9D5aUT0sTzsC1t1OJkTvf3uj8OsjA () mail ! gmail ! com
[Download RAW message or body]

I agree that passing the version via the command line might be a bit
excessive. However, by moving the other defines out of the config.h, we can
only specify them for the targets that actually use them which feels like
an improvement to me. I'll keep the config file to store the version but
maybe it should be renamed to version.h to more accurately reflect its
contents now.

Regards,

Daan

On Wed, 24 Jul 2019 at 11:23, Alex Turbov <i.zaufi@gmail.com> wrote:

> Hi,
>
> On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer <daan.j.demeyer@gmail.com>
> wrote:
>
>> The KATE_VERSION variable was used in some source files but by passing
>> the version as a command line define via CMake allowed me to remove the
>> config.h file completely.
>>
>
>  The good practice IMO is completely opposite: move `#defines` from CLI to
> generated `*.h` file(s) as much as you can. As for me, it'll make the CLI
> shorter and readable by humans w/ less pain. But the main reason: various
> shells have different limitations on CI length...
>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div>I agree that passing the version via the command line might be a \
bit excessive. However, by moving the other defines out of the config.h, we can only \
specify them for the targets that actually use them which feels like an improvement \
to me. I&#39;ll keep the config file to store the version but maybe it should be \
renamed to version.h to more accurately reflect its contents \
now.</div><div><br></div><div>Regards,</div><div><br></div><div>Daan<br> \
</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 24 \
Jul 2019 at 11:23, Alex Turbov &lt;<a \
href="mailto:i.zaufi@gmail.com">i.zaufi@gmail.com</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
dir="ltr">Hi,<br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer &lt;<a \
href="mailto:daan.j.demeyer@gmail.com" \
target="_blank">daan.j.demeyer@gmail.com</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>The KATE_VERSION variable was \
used in some source files but by passing the version as a command line define via \
CMake allowed me to remove the config.h file \
completely.</div></div></blockquote><div><br></div><div>  The good practice IMO is \
completely opposite: move `#defines` from CLI to generated `*.h` file(s) as much as \
you can. As for me, it&#39;ll make the CLI shorter and readable by humans w/ less \
pain. But the main reason: various shells have different limitations on CI \
length...</div><div><br></div></div></div> </blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]