--000000000000df56cc058e69dba5
Content-Type: text/plain; charset="UTF-8"

Hi,

On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer <daan.j.demeyer@gmail.com>
wrote:

> The KATE_VERSION variable was used in some source files but by passing the
> version as a command line define via CMake allowed me to remove the
> config.h file completely.
>

 The good practice IMO is completely opposite: move `#defines` from CLI to
generated `*.h` file(s) as much as you can. As for me, it'll make the CLI
shorter and readable by humans w/ less pain. But the main reason: various
shells have different limitations on CI length...

--000000000000df56cc058e69dba5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,<br></div><br><div class=3D"gmail_quot=
e"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jul 24, 2019 at 10:38 AM D=
aan De Meyer &lt;<a href=3D"mailto:daan.j.demeyer@gmail.com">daan.j.demeyer=
@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div dir=3D"ltr"><div>The KATE_VERSION variable was used in some=
 source files but by passing the version as a command line define via CMake=
 allowed me to remove the config.h file completely.</div></div></blockquote=
><div><br></div><div>=C2=A0The good practice IMO is completely opposite: mo=
ve `#defines` from CLI to generated `*.h` file(s) as much as you can. As fo=
r me, it&#39;ll make the CLI shorter and readable by humans w/ less pain. B=
ut the main reason: various shells have different limitations on CI length.=
..</div><div><br></div></div></div>

--000000000000df56cc058e69dba5--