[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 129022: Improve Markdown H1 - H6 syntax highlighting
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2016-11-13 11:24:35
Message-ID: 20161113112435.6207.94688 () mimi ! kde ! org
[Download RAW message or body]
--===============6691505684348330786==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 27, 2016, 8:11 p.m., Dominik Haumann wrote:
> > We are trying hard to avoid hard-coded colors, since these will not work nicely \
> > with other color themes. Therefore, we even remove hard-coded colors whenever we \
> > can and find the time.
> > As such, this review request is rejected.
> >
> > The good news is that starting with Kate 5, we added many more default styles, \
> > see: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
> >
> > Please use default styles from there, like dsExtension, dsBuiltIn, \
> > dsAttribute,... Then you will also achieve the same as now without hard-coded \
> > colors.
> > Please post an update then there.
Yes, please avoid hard coded colors.
If you update this, please post a review request for syntax-highlighting framework, \
the definitions are moving there.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129022/#review99599
-----------------------------------------------------------
On Sept. 27, 2016, 8:12 p.m., Dotan Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129022/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2016, 8:12 p.m.)
>
>
> Review request for Kate and Dotan Cohen.
>
>
> Repository: syntax-highlighting
>
>
> Description
> -------
>
> Edit six lines of code representing the H1 to H6 syntax highlighting format.
>
>
> Diffs
> -----
>
> data/syntax/markdown.xml 7fe2043
>
> Diff: https://git.reviewboard.kde.org/r/129022/diff/
>
>
> Testing
> -------
>
> Examine the Syntax Highlighting on a markdown file:
>
> $ cat test.markdown
>
> # Top Level Header
>
> ## Second Level Header
>
> ### Third Level Header
>
> #### Fourth
>
> ##### Fifth
>
> ###### Sixth
>
>
> Thanks,
>
> Dotan Cohen
>
>
--===============6691505684348330786==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129022/">https://git.reviewboard.kde.org/r/129022/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 27th, 2016, 8:11 p.m. UTC, <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We are trying hard to avoid hard-coded colors, since \
these will not work nicely with other color themes. Therefore, we even remove \
hard-coded colors whenever we can and find the time.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
such, this review request is rejected.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The good news is that \
starting with Kate 5, we added many more default styles, see: \
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Please use default styles from there, like \
dsExtension, dsBuiltIn, dsAttribute,... Then you will also achieve the same as now \
without hard-coded colors.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Please post an update then \
there.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
please avoid hard coded colors. If you update this, please post a review request for \
syntax-highlighting framework, the definitions are moving there.</p></pre> <br />
<p>- Christoph</p>
<br />
<p>On September 27th, 2016, 8:12 p.m. UTC, Dotan Cohen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate and Dotan Cohen.</div>
<div>By Dotan Cohen.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2016, 8:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
syntax-highlighting
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Edit six lines of code representing the H1 to H6 \
syntax highlighting format.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Examine the Syntax Highlighting on a markdown \
file:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">$ cat test.markdown</p> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Top Level Header</h1> <h2 style="font-size: 100%;text-rendering: \
inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Second Level \
Header</h2> <h3 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Third Level Header</h3> <h4 \
style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Fourth</h4> <h5 style="font-size: 100%;text-rendering: \
inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Fifth</h5> \
<h6 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">Sixth</h6></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/syntax/markdown.xml <span style="color: grey">(7fe2043)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129022/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6691505684348330786==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic