[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 129313: python syntax: added f-literals and improved string handling
From:       Christoph Cullmann <cullmann () kde ! org>
Date:       2016-11-13 11:22:43
Message-ID: 20161113112243.6207.74372 () mimi ! kde ! org
[Download RAW message or body]

--===============8515443701663067443==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129313/#review100812
-----------------------------------------------------------



Hi,

could you redo this against syntax-highlighting.git and extend the python unit test \
(autotests/input/test.py I think).

- Christoph Cullmann


On Nov. 2, 2016, 6:59 p.m., Philipp A. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129313/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 6:59 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> python syntax: added f-literals and improved string handling
> 
> 
> Diffs
> -----
> 
> src/syntax/data/python-f-literal-test.py PRE-CREATION 
> src/syntax/data/python.xml 670e22a9add3af0458a81a2fde2af7247fc45d65 
> 
> Diff: https://git.reviewboard.kde.org/r/129313/diff/
> 
> 
> Testing
> -------
> 
> see committed python test file
> 
> 
> Thanks,
> 
> Philipp A.
> 
> 


--===============8515443701663067443==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129313/">https://git.reviewboard.kde.org/r/129313/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Hi,</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">could you redo this against syntax-highlighting.git \
and extend the python unit test (autotests/input/test.py I think).</p></pre>  <br />









<p>- Christoph Cullmann</p>


<br />
<p>On November 2nd, 2016, 6:59 p.m. UTC, Philipp A. wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Philipp A..</div>


<p style="color: grey;"><i>Updated Nov. 2, 2016, 6:59 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">python syntax: added f-literals and improved string handling</pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see committed python test file</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/syntax/data/python-f-literal-test.py <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/syntax/data/python.xml <span style="color: \
grey">(670e22a9add3af0458a81a2fde2af7247fc45d65)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129313/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============8515443701663067443==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic