From kwrite-devel Sun Nov 13 11:24:35 2016 From: Christoph Cullmann Date: Sun, 13 Nov 2016 11:24:35 +0000 To: kwrite-devel Subject: Re: Review Request 129022: Improve Markdown H1 - H6 syntax highlighting Message-Id: <20161113112435.6207.94688 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=147903627913879 --===============6691505684348330786== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 27, 2016, 8:11 p.m., Dominik Haumann wrote: > > We are trying hard to avoid hard-coded colors, since these will not work nicely with other color themes. > > Therefore, we even remove hard-coded colors whenever we can and find the time. > > > > As such, this review request is rejected. > > > > The good news is that starting with Kate 5, we added many more default styles, see: > > https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/ > > > > Please use default styles from there, like dsExtension, dsBuiltIn, dsAttribute,... > > Then you will also achieve the same as now without hard-coded colors. > > > > Please post an update then there. Yes, please avoid hard coded colors. If you update this, please post a review request for syntax-highlighting framework, the definitions are moving there. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129022/#review99599 ----------------------------------------------------------- On Sept. 27, 2016, 8:12 p.m., Dotan Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129022/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 8:12 p.m.) > > > Review request for Kate and Dotan Cohen. > > > Repository: syntax-highlighting > > > Description > ------- > > Edit six lines of code representing the H1 to H6 syntax highlighting format. > > > Diffs > ----- > > data/syntax/markdown.xml 7fe2043 > > Diff: https://git.reviewboard.kde.org/r/129022/diff/ > > > Testing > ------- > > Examine the Syntax Highlighting on a markdown file: > > $ cat test.markdown > > # Top Level Header > > ## Second Level Header > > ### Third Level Header > > #### Fourth > > ##### Fifth > > ###### Sixth > > > Thanks, > > Dotan Cohen > > --===============6691505684348330786== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129022/

On September 27th, 2016, 8:11 p.m. UTC, Dominik Haumann wrote:

We are trying hard to avoid hard-coded colors, since these will not work nicely with other color themes.
Therefore, we even remove hard-coded colors whenever we can and find the time.


As such, this review request is rejected.


The good news is that starting with Kate 5, we added many more default styles, see:
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/


Please use default styles from there, like dsExtension, dsBuiltIn, dsAttribute,...
Then you will also achieve the same as now without hard-coded colors.


Please post an update then there.
Yes, please avoid hard coded colors.
If you update this, please post a review request for syntax-highlighting framework, the definitions are moving there.

- Christoph


On September 27th, 2016, 8:12 p.m. UTC, Dotan Cohen wrote:

Review request for Kate and Dotan Cohen.
By Dotan Cohen.

Updated Sept. 27, 2016, 8:12 p.m.

Repository: syntax-highlighting

Description 

Edit six lines of code representing the H1 to H6 syntax highlighting format.

Testing 

Examine the Syntax Highlighting on a markdown file:


$ cat test.markdown


Top Level Header


Second Level Header


Third Level Header


Fourth


Fifth


Sixth

Diffs

  • data/syntax/markdown.xml (7fe2043)

View Diff
--===============6691505684348330786==--