[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 116946: part: Constructors with one argument made explicit
From: "Harsh Kumar" <harsh1kumar () gmail ! com>
Date: 2014-03-26 21:56:46
Message-ID: 20140326215646.24148.3072 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116946/
-----------------------------------------------------------
(Updated March 26, 2014, 9:56 p.m.)
Status
------
This change has been discarded.
Review request for Kate.
Repository: kate
Description
-------
Constructors with one argument should be made explicit unless there is a requirement \
for implicit conversion. Making such constructors explicit would avoid wrong implicit \
conversions.
Diffs
-----
part/snippet/snippetrepository.h c29f182
part/snippet/snippetstore.h 88fcfda
part/spellcheck/ontheflycheck.h 991f7d0
part/spellcheck/spellcheck.h 87d5d53
part/spellcheck/spellingmenu.h 680e134
part/syntax/katehighlight.h c2d4397
part/undo/kateundo.h fa25b61
part/undo/kateundomanager.h ab361ee
part/utils/kateconfig.h c0407f7
part/utils/katepartpluginmanager.h 5543bb0
part/variableeditor/katehelpbutton.h f5ed181
part/variableeditor/variableeditor.h 86f8647
part/variableeditor/variableitem.h 4db9d13
part/variableeditor/variablelistview.h 197b019
part/view/katefadeeffect.h a43ed6a
part/view/katemessagewidget.h f4adb87
part/view/kateviewinternal.h 82283b2
part/buffer/katetextbuffer.h dddded6
part/buffer/katetextfolding.h a3d6412
part/buffer/katetextline.h 5e13dcc
part/completion/expandingtree/expandingtree.h ad29e62
part/completion/expandingtree/expandingwidgetmodel.h f9ced29
part/completion/kateargumenthintmodel.h 90b4a47
part/completion/kateargumenthinttree.h 4073255
part/completion/katecompletionmodel.h a10a533
part/completion/katekeywordcompletion.h 1fe254a
part/completion/katewordcompletion.h 623b560
part/dialogs/katedialogs.h 0971e4b
part/kte5/documentcursor.h 7ee2bd2
part/render/katelinelayout.h ba46baf
part/schema/kateschemaconfig.h be1139e
part/script/katescript.h e39e4a9
part/script/katescriptdocument.h 2a3fd3e
part/script/katescriptview.h 5bef8f1
part/script/katetemplatescript.h 3823c81
part/snippet/katesnippetglobal.h d106dfe
part/snippet/snippetfilterproxymodel.h cb2bc5d
Diff: https://git.reviewboard.kde.org/r/116946/diff/
Testing
-------
Compiled.
If there was any use of constructor for implicit conversion, it would have given \
compile time error. There was no error in compiling.
Thanks,
Harsh Kumar
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116946/">https://git.reviewboard.kde.org/r/116946/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Harsh Kumar.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 9:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Constructors with one argument should be made explicit unless there is a \
requirement for implicit conversion. Making such constructors explicit would avoid \
wrong implicit conversions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled.
If there was any use of constructor for implicit conversion, it would have given \
compile time error. There was no error in compiling.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/snippet/snippetrepository.h <span style="color: grey">(c29f182)</span></li>
<li>part/snippet/snippetstore.h <span style="color: grey">(88fcfda)</span></li>
<li>part/spellcheck/ontheflycheck.h <span style="color: grey">(991f7d0)</span></li>
<li>part/spellcheck/spellcheck.h <span style="color: grey">(87d5d53)</span></li>
<li>part/spellcheck/spellingmenu.h <span style="color: grey">(680e134)</span></li>
<li>part/syntax/katehighlight.h <span style="color: grey">(c2d4397)</span></li>
<li>part/undo/kateundo.h <span style="color: grey">(fa25b61)</span></li>
<li>part/undo/kateundomanager.h <span style="color: grey">(ab361ee)</span></li>
<li>part/utils/kateconfig.h <span style="color: grey">(c0407f7)</span></li>
<li>part/utils/katepartpluginmanager.h <span style="color: \
grey">(5543bb0)</span></li>
<li>part/variableeditor/katehelpbutton.h <span style="color: \
grey">(f5ed181)</span></li>
<li>part/variableeditor/variableeditor.h <span style="color: \
grey">(86f8647)</span></li>
<li>part/variableeditor/variableitem.h <span style="color: \
grey">(4db9d13)</span></li>
<li>part/variableeditor/variablelistview.h <span style="color: \
grey">(197b019)</span></li>
<li>part/view/katefadeeffect.h <span style="color: grey">(a43ed6a)</span></li>
<li>part/view/katemessagewidget.h <span style="color: grey">(f4adb87)</span></li>
<li>part/view/kateviewinternal.h <span style="color: grey">(82283b2)</span></li>
<li>part/buffer/katetextbuffer.h <span style="color: grey">(dddded6)</span></li>
<li>part/buffer/katetextfolding.h <span style="color: grey">(a3d6412)</span></li>
<li>part/buffer/katetextline.h <span style="color: grey">(5e13dcc)</span></li>
<li>part/completion/expandingtree/expandingtree.h <span style="color: \
grey">(ad29e62)</span></li>
<li>part/completion/expandingtree/expandingwidgetmodel.h <span style="color: \
grey">(f9ced29)</span></li>
<li>part/completion/kateargumenthintmodel.h <span style="color: \
grey">(90b4a47)</span></li>
<li>part/completion/kateargumenthinttree.h <span style="color: \
grey">(4073255)</span></li>
<li>part/completion/katecompletionmodel.h <span style="color: \
grey">(a10a533)</span></li>
<li>part/completion/katekeywordcompletion.h <span style="color: \
grey">(1fe254a)</span></li>
<li>part/completion/katewordcompletion.h <span style="color: \
grey">(623b560)</span></li>
<li>part/dialogs/katedialogs.h <span style="color: grey">(0971e4b)</span></li>
<li>part/kte5/documentcursor.h <span style="color: grey">(7ee2bd2)</span></li>
<li>part/render/katelinelayout.h <span style="color: grey">(ba46baf)</span></li>
<li>part/schema/kateschemaconfig.h <span style="color: grey">(be1139e)</span></li>
<li>part/script/katescript.h <span style="color: grey">(e39e4a9)</span></li>
<li>part/script/katescriptdocument.h <span style="color: grey">(2a3fd3e)</span></li>
<li>part/script/katescriptview.h <span style="color: grey">(5bef8f1)</span></li>
<li>part/script/katetemplatescript.h <span style="color: grey">(3823c81)</span></li>
<li>part/snippet/katesnippetglobal.h <span style="color: grey">(d106dfe)</span></li>
<li>part/snippet/snippetfilterproxymodel.h <span style="color: \
grey">(cb2bc5d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116946/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic