[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 116945: addons: Constructors with one argument made explicit
From: "Harsh Kumar" <harsh1kumar () gmail ! com>
Date: 2014-03-26 21:56:56
Message-ID: 20140326215656.18781.69114 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116945/
-----------------------------------------------------------
(Updated March 26, 2014, 9:56 p.m.)
Status
------
This change has been discarded.
Review request for Kate.
Repository: kate
Description
-------
Constructors with one argument should be made explicit unless there is a requirement \
for implicit conversion. Making such constructors explicit would avoid wrong implicit \
conversions.
Diffs
-----
addons/kate/gdbplugin/localsview.h febfaf3
addons/kate/helloworld/plugin_katehelloworld.h 895fac5
addons/kate/katebuild-plugin/plugin_katebuild.h fc47471
addons/kate/katebuild-plugin/targets.h 27b3db2
addons/kate/katesql/connectionmodel.h dd656c0
addons/kate/katesql/connectionwizard.h 63d8aef
addons/kate/katesql/dataoutputmodel.h fdc40b9
addons/kate/katesql/dataoutputview.h 8e80790
addons/kate/katesql/dataoutputwidget.h 4bfa0fe
addons/kate/katesql/exportwizard.h aeb3835
addons/kate/katesql/outputstylewidget.h ee31e5d
addons/kate/katesql/outputwidget.h 586800d
addons/kate/katesql/sqlmanager.h e877828
addons/kate/katesql/textoutputwidget.h 94b4af1
addons/kate/mailfiles/katemailfiles.h 9d3c110
addons/kate/project/kateproject.h 3aaed67
addons/kate/project/kateprojectcompletion.h 166f50c
addons/kate/project/kateprojectindex.h 36d1fe0
addons/kate/project/kateprojectworker.h ea57cd3
addons/kate/replicode/replicodeconfigpage.h 3fdeda5
addons/kate/search/FolderFilesList.h e27a8fd
addons/kate/search/SearchDiskFiles.h de46f74
addons/kate/search/plugin_search.h 9821cce
addons/kate/search/replace_matches.h c015e53
addons/kate/search/search_open_files.h 547e9c5
addons/kate/tabbarextension/ktinytabbar.h c3a3120
addons/kate/tabbarextension/ktinytabbarconfigpage.h a9bac22
addons/kate/tabbarextension/plugin_katetabbarextension.h 9b63c3b
addons/kate/xmlcheck/plugin_katexmlcheck.h 1e75eb0
addons/kate/xmltools/plugin_katexmltools.h 2260403
addons/ktexteditor/exporter/exporterpluginview.h 9e3e52a
addons/ktexteditor/kte_iconinserter/iconinserterplugin.h 8f94a6a
addons/ktexteditor/lumen/lumen.h 17e0fac
addons/kate/backtracebrowser/btfileindexer.h 2dd4e5f
addons/kate/backtracebrowser/katebacktracebrowser.h e07196b
addons/kate/close-except-like/close_except_plugin.h 8d2f1e1
addons/kate/filebrowser/katefilebrowserplugin.h 7ef42be
addons/kate/filetemplates/plugin/filetemplates.h 5f559e4
addons/kate/gdbplugin/advanced_settings.h 6778f01
addons/kate/gdbplugin/debugview.h 3b64dee
addons/kate/gdbplugin/ioview.h a3d1a64
Diff: https://git.reviewboard.kde.org/r/116945/diff/
Testing
-------
Compiled.
If there was any use of constructor for implicit conversion, it would have given \
compile time error. There was no error in compiling.
Thanks,
Harsh Kumar
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116945/">https://git.reviewboard.kde.org/r/116945/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Harsh Kumar.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 9:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Constructors with one argument should be made explicit unless there is a \
requirement for implicit conversion. Making such constructors explicit would avoid \
wrong implicit conversions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled.
If there was any use of constructor for implicit conversion, it would have given \
compile time error. There was no error in compiling.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/kate/gdbplugin/localsview.h <span style="color: \
grey">(febfaf3)</span></li>
<li>addons/kate/helloworld/plugin_katehelloworld.h <span style="color: \
grey">(895fac5)</span></li>
<li>addons/kate/katebuild-plugin/plugin_katebuild.h <span style="color: \
grey">(fc47471)</span></li>
<li>addons/kate/katebuild-plugin/targets.h <span style="color: \
grey">(27b3db2)</span></li>
<li>addons/kate/katesql/connectionmodel.h <span style="color: \
grey">(dd656c0)</span></li>
<li>addons/kate/katesql/connectionwizard.h <span style="color: \
grey">(63d8aef)</span></li>
<li>addons/kate/katesql/dataoutputmodel.h <span style="color: \
grey">(fdc40b9)</span></li>
<li>addons/kate/katesql/dataoutputview.h <span style="color: \
grey">(8e80790)</span></li>
<li>addons/kate/katesql/dataoutputwidget.h <span style="color: \
grey">(4bfa0fe)</span></li>
<li>addons/kate/katesql/exportwizard.h <span style="color: \
grey">(aeb3835)</span></li>
<li>addons/kate/katesql/outputstylewidget.h <span style="color: \
grey">(ee31e5d)</span></li>
<li>addons/kate/katesql/outputwidget.h <span style="color: \
grey">(586800d)</span></li>
<li>addons/kate/katesql/sqlmanager.h <span style="color: grey">(e877828)</span></li>
<li>addons/kate/katesql/textoutputwidget.h <span style="color: \
grey">(94b4af1)</span></li>
<li>addons/kate/mailfiles/katemailfiles.h <span style="color: \
grey">(9d3c110)</span></li>
<li>addons/kate/project/kateproject.h <span style="color: \
grey">(3aaed67)</span></li>
<li>addons/kate/project/kateprojectcompletion.h <span style="color: \
grey">(166f50c)</span></li>
<li>addons/kate/project/kateprojectindex.h <span style="color: \
grey">(36d1fe0)</span></li>
<li>addons/kate/project/kateprojectworker.h <span style="color: \
grey">(ea57cd3)</span></li>
<li>addons/kate/replicode/replicodeconfigpage.h <span style="color: \
grey">(3fdeda5)</span></li>
<li>addons/kate/search/FolderFilesList.h <span style="color: \
grey">(e27a8fd)</span></li>
<li>addons/kate/search/SearchDiskFiles.h <span style="color: \
grey">(de46f74)</span></li>
<li>addons/kate/search/plugin_search.h <span style="color: \
grey">(9821cce)</span></li>
<li>addons/kate/search/replace_matches.h <span style="color: \
grey">(c015e53)</span></li>
<li>addons/kate/search/search_open_files.h <span style="color: \
grey">(547e9c5)</span></li>
<li>addons/kate/tabbarextension/ktinytabbar.h <span style="color: \
grey">(c3a3120)</span></li>
<li>addons/kate/tabbarextension/ktinytabbarconfigpage.h <span style="color: \
grey">(a9bac22)</span></li>
<li>addons/kate/tabbarextension/plugin_katetabbarextension.h <span style="color: \
grey">(9b63c3b)</span></li>
<li>addons/kate/xmlcheck/plugin_katexmlcheck.h <span style="color: \
grey">(1e75eb0)</span></li>
<li>addons/kate/xmltools/plugin_katexmltools.h <span style="color: \
grey">(2260403)</span></li>
<li>addons/ktexteditor/exporter/exporterpluginview.h <span style="color: \
grey">(9e3e52a)</span></li>
<li>addons/ktexteditor/kte_iconinserter/iconinserterplugin.h <span style="color: \
grey">(8f94a6a)</span></li>
<li>addons/ktexteditor/lumen/lumen.h <span style="color: grey">(17e0fac)</span></li>
<li>addons/kate/backtracebrowser/btfileindexer.h <span style="color: \
grey">(2dd4e5f)</span></li>
<li>addons/kate/backtracebrowser/katebacktracebrowser.h <span style="color: \
grey">(e07196b)</span></li>
<li>addons/kate/close-except-like/close_except_plugin.h <span style="color: \
grey">(8d2f1e1)</span></li>
<li>addons/kate/filebrowser/katefilebrowserplugin.h <span style="color: \
grey">(7ef42be)</span></li>
<li>addons/kate/filetemplates/plugin/filetemplates.h <span style="color: \
grey">(5f559e4)</span></li>
<li>addons/kate/gdbplugin/advanced_settings.h <span style="color: \
grey">(6778f01)</span></li>
<li>addons/kate/gdbplugin/debugview.h <span style="color: \
grey">(3b64dee)</span></li>
<li>addons/kate/gdbplugin/ioview.h <span style="color: grey">(a3d1a64)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116945/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic