[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 116944: kate & kwrite: Constructors with one argument made explicit
From: "Harsh Kumar" <harsh1kumar () gmail ! com>
Date: 2014-03-26 21:56:34
Message-ID: 20140326215634.24148.52433 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116944/
-----------------------------------------------------------
(Updated March 26, 2014, 9:56 p.m.)
Status
------
This change has been discarded.
Review request for Kate.
Repository: kate
Description
-------
Constructors with one argument should be made explicit unless there is a requirement \
for implicit conversion. Making such constructors explicit would avoid wrong implicit \
conversions.
Diffs
-----
kate/interfaces/kate/mainwindow.h 0c4be6b
kate/interfaces/kate/plugin.h 78b2f73
kate/interfaces/kate/pluginmanager.h 680516d
kwrite/kwriteapp.h e9f7ebd
kwrite/kwritemain.h fabcba9
kate/app/kateapp.h f2d6917
kate/app/kateappadaptor.h 61e3799
kate/app/kateconfigplugindialogpage.h c7b4f2f
kate/app/katecontainer.h c6bb1f6
kate/app/katedocmanager.h 8c1c700
kate/app/katemainwindow.h 6037117
kate/app/katemdi.h 8662cc1
kate/app/katepluginmanager.h e6ce266
kate/app/katerunninginstanceinfo.h d3aae17
kate/app/katesession.h 1b0ae23
kate/app/kateviewspace.h 00314da
kate/filetree/katefiletree.h 1c4362c
kate/filetree/katefiletreemodel.h a1756ab
kate/filetree/katefiletreeplugin.h 0b18850
kate/filetree/katefiletreeproxymodel.h 8395e7c
kate/interfaces/kate/application.h e65e474
kate/interfaces/kate/documentmanager.h 6f35130
Diff: https://git.reviewboard.kde.org/r/116944/diff/
Testing
-------
Compiled.
If there was any use of constructor for implicit conversion, it would have given \
compile time error. There was no error in compiling.
Thanks,
Harsh Kumar
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116944/">https://git.reviewboard.kde.org/r/116944/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Harsh Kumar.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 9:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Constructors with one argument should be made explicit unless there is a \
requirement for implicit conversion. Making such constructors explicit would avoid \
wrong implicit conversions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled.
If there was any use of constructor for implicit conversion, it would have given \
compile time error. There was no error in compiling.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/interfaces/kate/mainwindow.h <span style="color: \
grey">(0c4be6b)</span></li>
<li>kate/interfaces/kate/plugin.h <span style="color: grey">(78b2f73)</span></li>
<li>kate/interfaces/kate/pluginmanager.h <span style="color: \
grey">(680516d)</span></li>
<li>kwrite/kwriteapp.h <span style="color: grey">(e9f7ebd)</span></li>
<li>kwrite/kwritemain.h <span style="color: grey">(fabcba9)</span></li>
<li>kate/app/kateapp.h <span style="color: grey">(f2d6917)</span></li>
<li>kate/app/kateappadaptor.h <span style="color: grey">(61e3799)</span></li>
<li>kate/app/kateconfigplugindialogpage.h <span style="color: \
grey">(c7b4f2f)</span></li>
<li>kate/app/katecontainer.h <span style="color: grey">(c6bb1f6)</span></li>
<li>kate/app/katedocmanager.h <span style="color: grey">(8c1c700)</span></li>
<li>kate/app/katemainwindow.h <span style="color: grey">(6037117)</span></li>
<li>kate/app/katemdi.h <span style="color: grey">(8662cc1)</span></li>
<li>kate/app/katepluginmanager.h <span style="color: grey">(e6ce266)</span></li>
<li>kate/app/katerunninginstanceinfo.h <span style="color: \
grey">(d3aae17)</span></li>
<li>kate/app/katesession.h <span style="color: grey">(1b0ae23)</span></li>
<li>kate/app/kateviewspace.h <span style="color: grey">(00314da)</span></li>
<li>kate/filetree/katefiletree.h <span style="color: grey">(1c4362c)</span></li>
<li>kate/filetree/katefiletreemodel.h <span style="color: \
grey">(a1756ab)</span></li>
<li>kate/filetree/katefiletreeplugin.h <span style="color: \
grey">(0b18850)</span></li>
<li>kate/filetree/katefiletreeproxymodel.h <span style="color: \
grey">(8395e7c)</span></li>
<li>kate/interfaces/kate/application.h <span style="color: \
grey">(e65e474)</span></li>
<li>kate/interfaces/kate/documentmanager.h <span style="color: \
grey">(6f35130)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116944/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic