'Review Request 114763: fix find previous button in KateSearchBar in vi-mode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request 114763: fix find previous button in KateSearchBar in vi-mode
From:       "Michal Humpula" <michal.humpula () seznam ! cz>
Date:       2013-12-31 16:41:31
Message-ID: 20131231164131.1620.31877 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114763/
-----------------------------------------------------------

Review request for Kate and Simon St James.

Bugs: 329468
    http://bugs.kde.org/show_bug.cgi?id=329468

Repository: kate

Description
-------

This is nasty fix for the bug. Seems that nothing else is broken by the patch.

Reasoning: the KateSearchBar is placing cursor at the end of a search text. But in \
vi-mode it doesn't select the text (we want to able to search in visual mode and \
automaticaly extend already selected text when cursor jumps). Which is the problem, \
when the backward search kicks in and finds the already searched word just before the \
cursor. Normaly the selection would be detected and skipped, but in vi-mode there is \
no selection, hence "nothing" happens.

For the frameworks, if vi-mode overloads the search menu actions and \
VimStyleCommandBar will be invoked instead, the vi-dependent code from KateSearchBar \
could be completely cut out.

Diffs
-----

  part/search/katesearchbar.cpp baa4923 

Diff: https://git.reviewboard.kde.org/r/114763/diff/

Testing
-------

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114763/">https://git.reviewboard.kde.org/r/114763/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Simon St James.</div>
<div>By Michal Humpula.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=329468">329468</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is nasty fix for the bug. Seems that nothing else is broken by the \
patch.

Reasoning: the KateSearchBar is placing cursor at the end of a search text. But in \
vi-mode it doesn&#39;t select the text (we want to able to search in visual mode and \
automaticaly extend already selected text when cursor jumps). Which is the problem, \
when the backward search kicks in and finds the already searched word just before the \
cursor. Normaly the selection would be detected and skipped, but in vi-mode there is \
no selection, hence &quot;nothing&quot; happens.

For the frameworks, if vi-mode overloads the search menu actions and \
VimStyleCommandBar will be invoked instead, the vi-dependent code from KateSearchBar \
could be completely cut out.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/search/katesearchbar.cpp <span style="color: grey">(baa4923)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114763/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 