From kwrite-devel Tue Dec 31 16:41:31 2013 From: "Michal Humpula" Date: Tue, 31 Dec 2013 16:41:31 +0000 To: kwrite-devel Subject: Review Request 114763: fix find previous button in KateSearchBar in vi-mode Message-Id: <20131231164131.1620.31877 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=138850820225450 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6056229913946947180==" --===============6056229913946947180== Content-Type: multipart/alternative; boundary="===============1970223988748464671==" --===============1970223988748464671== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114763/ ----------------------------------------------------------- Review request for Kate and Simon St James. Bugs: 329468 http://bugs.kde.org/show_bug.cgi?id=329468 Repository: kate Description ------- This is nasty fix for the bug. Seems that nothing else is broken by the patch. Reasoning: the KateSearchBar is placing cursor at the end of a search text. But in vi-mode it doesn't select the text (we want to able to search in visual mode and automaticaly extend already selected text when cursor jumps). Which is the problem, when the backward search kicks in and finds the already searched word just before the cursor. Normaly the selection would be detected and skipped, but in vi-mode there is no selection, hence "nothing" happens. For the frameworks, if vi-mode overloads the search menu actions and VimStyleCommandBar will be invoked instead, the vi-dependent code from KateSearchBar could be completely cut out. Diffs ----- part/search/katesearchbar.cpp baa4923 Diff: https://git.reviewboard.kde.org/r/114763/diff/ Testing ------- Thanks, Michal Humpula --===============1970223988748464671== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114763/

Review request for Kate and Simon St James.

By Michal Humpula.

Bugs: 329468

Repository: kate

Description

This is nasty fix for the bug. Seems that nothing else is broken by the patch.

Reasoning: the KateSearchBar is placing cursor at the end of a search text. But in vi-mode it doesn't select the text (we want to able to search in visual mode and automaticaly extend already selected text when cursor jumps). Which is the problem, when the backward search kicks in and finds the already searched word just before the cursor. Normaly the selection would be detected and skipped, but in vi-mode there is no selection, hence "nothing" happens.

For the frameworks, if vi-mode overloads the search menu actions and VimStyleCommandBar will be invoked instead, the vi-dependent code from KateSearchBar could be completely cut out.

Diffs

part/search/katesearchbar.cpp (baa4923)

View Diff

--===============1970223988748464671==-- --===============6056229913946947180== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============6056229913946947180==--