This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114763/

Review request for Kate and Simon St James.
By Michal Humpula.
Bugs: 329468
Repository: kate

Description

This is nasty fix for the bug. Seems that nothing else is broken by the patch.

Reasoning: the KateSearchBar is placing cursor at the end of a search text. But in vi-mode it doesn't select the text (we want to able to search in visual mode and automaticaly extend already selected text when cursor jumps). Which is the problem, when the backward search kicks in and finds the already searched word just before the cursor. Normaly the selection would be detected and skipped, but in vi-mode there is no selection, hence "nothing" happens.

For the frameworks, if vi-mode overloads the search menu actions and VimStyleCommandBar will be invoked instead, the vi-dependent code from KateSearchBar could be completely cut out.

Diffs

  • part/search/katesearchbar.cpp (baa4923)

View Diff