[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114675: frameworks: move spellcheck dialog to bottomViewBar
From: "Michel Ludwig" <michel.ludwig () gmail ! com>
Date: 2013-12-29 16:14:19
Message-ID: 20131229161419.21905.66989 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114675/#review46383
-----------------------------------------------------------
A few suggestions for the layout from my side: do we still need a list widget that \
shows the suggestions? Wouldn't a combo box next to "Replace with" be sufficient?
I guess the "ok" and "cancel" buttons aren't necessary any more if we add a "close" \
(x) button (just as for the other side bars).
- Michel Ludwig
On Dec. 28, 2013, 2:01 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114675/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2013, 2:01 p.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 151461 and 221754
> http://bugs.kde.org/show_bug.cgi?id=151461
> http://bugs.kde.org/show_bug.cgi?id=221754
>
>
> Repository: kate
>
>
> Description
> -------
>
> As I understand, this was done for "search & replace" in KDE4. Not everybody is \
> using the tiled WM (sadly), so sometimes the dialog can get in a way.
> The dialog in sonnet is not cunstructed from widget as in KEncodingFileDialog, so I \
> had to copy the whole thing and rebase it from KateViewBarWidget instead.
> I've also touched the ui file a little bit, because the dialog is structured quite \
> verticaly but ViewBars are "constrained" in that direction. The result is not so \
> pleasant, though.
> Any ideas and comments are welcomed.
>
>
> Diffs
> -----
>
> part/CMakeLists.txt 6260ca3
> part/spellcheck/spellcheckbar.h PRE-CREATION
> part/spellcheck/spellcheckbar.cpp PRE-CREATION
> part/spellcheck/spellcheckbar.ui PRE-CREATION
> part/spellcheck/spellcheckdialog.h a728ed6
> part/spellcheck/spellcheckdialog.cpp c59fca7
>
> Diff: https://git.reviewboard.kde.org/r/114675/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114675/">https://git.reviewboard.kde.org/r/114675/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few suggestions for \
the layout from my side: do we still need a list widget that shows the suggestions? \
Wouldn't a combo box next to "Replace with" be sufficient?
I guess the "ok" and "cancel" buttons aren't necessary any \
more if we add a "close" (x) button (just as for the other side bars). \
</pre> <br />
<p>- Michel Ludwig</p>
<br />
<p>On December 28th, 2013, 2:01 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 2:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=151461">151461</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=221754">221754</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As I understand, this was done for "search & replace" in \
KDE4. Not everybody is using the tiled WM (sadly), so sometimes the dialog can get in \
a way.
The dialog in sonnet is not cunstructed from widget as in KEncodingFileDialog, so I \
had to copy the whole thing and rebase it from KateViewBarWidget instead.
I've also touched the ui file a little bit, because the dialog is structured \
quite verticaly but ViewBars are "constrained" in that direction. The \
result is not so pleasant, though.
Any ideas and comments are welcomed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/CMakeLists.txt <span style="color: grey">(6260ca3)</span></li>
<li>part/spellcheck/spellcheckbar.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/spellcheck/spellcheckbar.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/spellcheck/spellcheckbar.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/spellcheck/spellcheckdialog.h <span style="color: \
grey">(a728ed6)</span></li>
<li>part/spellcheck/spellcheckdialog.cpp <span style="color: \
grey">(c59fca7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114675/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic