This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114675/ 

A few suggestions for the layout from my side: do we still need a list widget that shows the suggestions? Wouldn't a combo box next to "Replace with" be sufficient?

I guess the "ok" and "cancel" buttons aren't necessary any more if we add a "close" (x) button (just as for the other side bars).

- Michel Ludwig


On December 28th, 2013, 2:01 p.m. UTC, Michal Humpula wrote:

Review request for Kate.
By Michal Humpula.

Updated Dec. 28, 2013, 2:01 p.m.

Bugs: 151461, 221754
Repository: kate

Description 

As I understand, this was done for "search & replace" in KDE4. Not everybody is using the tiled WM (sadly), so sometimes the dialog can get in a way.

The dialog in sonnet is not cunstructed from widget as in KEncodingFileDialog, so I had to copy the whole thing and rebase it from KateViewBarWidget instead.

I've also touched the ui file a little bit, because the dialog is structured quite verticaly but ViewBars are "constrained" in that direction. The result is not so pleasant, though.

Any ideas and comments are welcomed.

Diffs

  • part/CMakeLists.txt (6260ca3)
  • part/spellcheck/spellcheckbar.h (PRE-CREATION)
  • part/spellcheck/spellcheckbar.cpp (PRE-CREATION)
  • part/spellcheck/spellcheckbar.ui (PRE-CREATION)
  • part/spellcheck/spellcheckdialog.h (a728ed6)
  • part/spellcheck/spellcheckdialog.cpp (c59fca7)

View Diff