--===============2509111661923392646== Content-Type: multipart/alternative; boundary="===============7000762490286763954==" --===============7000762490286763954== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114675/#review46383 ----------------------------------------------------------- A few suggestions for the layout from my side: do we still need a list widget that shows the suggestions? Wouldn't a combo box next to "Replace with" be sufficient? I guess the "ok" and "cancel" buttons aren't necessary any more if we add a "close" (x) button (just as for the other side bars). - Michel Ludwig On Dec. 28, 2013, 2:01 p.m., Michal Humpula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114675/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2013, 2:01 p.m.) > > > Review request for Kate. > > > Bugs: 151461 and 221754 > http://bugs.kde.org/show_bug.cgi?id=151461 > http://bugs.kde.org/show_bug.cgi?id=221754 > > > Repository: kate > > > Description > ------- > > As I understand, this was done for "search & replace" in KDE4. Not everybody is using the tiled WM (sadly), so sometimes the dialog can get in a way. > > The dialog in sonnet is not cunstructed from widget as in KEncodingFileDialog, so I had to copy the whole thing and rebase it from KateViewBarWidget instead. > > I've also touched the ui file a little bit, because the dialog is structured quite verticaly but ViewBars are "constrained" in that direction. The result is not so pleasant, though. > > Any ideas and comments are welcomed. > > > Diffs > ----- > > part/CMakeLists.txt 6260ca3 > part/spellcheck/spellcheckbar.h PRE-CREATION > part/spellcheck/spellcheckbar.cpp PRE-CREATION > part/spellcheck/spellcheckbar.ui PRE-CREATION > part/spellcheck/spellcheckdialog.h a728ed6 > part/spellcheck/spellcheckdialog.cpp c59fca7 > > Diff: https://git.reviewboard.kde.org/r/114675/diff/ > > > Testing > ------- > > > Thanks, > > Michal Humpula > > --===============7000762490286763954== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114675/ 

A few suggestions for the layout from my side: do we still need a list widget that shows the suggestions? Wouldn't a combo box next to "Replace with" be sufficient?

I guess the "ok" and "cancel" buttons aren't necessary any more if we add a "close" (x) button (just as for the other side bars).

- Michel Ludwig


On December 28th, 2013, 2:01 p.m. UTC, Michal Humpula wrote:

Review request for Kate.
By Michal Humpula.

Updated Dec. 28, 2013, 2:01 p.m.

Bugs: 151461, 221754
Repository: kate

Description 

As I understand, this was done for "search & replace" in KDE4. Not everybody is using the tiled WM (sadly), so sometimes the dialog can get in a way.

The dialog in sonnet is not cunstructed from widget as in KEncodingFileDialog, so I had to copy the whole thing and rebase it from KateViewBarWidget instead.

I've also touched the ui file a little bit, because the dialog is structured quite verticaly but ViewBars are "constrained" in that direction. The result is not so pleasant, though.

Any ideas and comments are welcomed.

Diffs

  • part/CMakeLists.txt (6260ca3)
  • part/spellcheck/spellcheckbar.h (PRE-CREATION)
  • part/spellcheck/spellcheckbar.cpp (PRE-CREATION)
  • part/spellcheck/spellcheckbar.ui (PRE-CREATION)
  • part/spellcheck/spellcheckdialog.h (a728ed6)
  • part/spellcheck/spellcheckdialog.cpp (c59fca7)

View Diff
--===============7000762490286763954==-- --===============2509111661923392646== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============2509111661923392646==--