[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 113917: WIP: Fix crash in ~QPersistentIndex
From: "Milian Wolff" <mail () milianw ! de>
Date: 2013-12-29 13:28:41
Message-ID: 20131229132841.21905.32075 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113917/#review46376
-----------------------------------------------------------
Is the performance good now? patch looks really promising, one small issue and one \
open question otherwise fine with me! Thanks!
part/completion/katecompletionmodel.h
<https://git.reviewboard.kde.org/r/113917/#comment33071>
explicit qualification of the identifier is not required here (probably KDevelop \
added it?)
part/completion/katecompletionmodel.cpp
<https://git.reviewboard.kde.org/r/113917/#comment33072>
this is called above just after a begin/endReset. Thus potentially this could be \
merged into that section yielding a potential performance gain as the view doesn't \
have to react twice on the reset?
- Milian Wolff
On Dec. 28, 2013, 10:54 p.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113917/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2013, 10:54 p.m.)
>
>
> Review request for Kate and Milian Wolff.
>
>
> Bugs: 236948
> http://bugs.kde.org/show_bug.cgi?id=236948
>
>
> Repository: kate
>
>
> Description
> -------
>
> WIP: Fix crash in ~QPersistentIndex
>
>
> Diffs
> -----
>
> part/completion/katecompletionmodel.cpp 3fa8080ff95deb1e24327063ccd19dbb13ff49a8
> part/completion/katecompletionwidget.cpp 4bb077e0973fd1eb9f1f5a7bb3e9bccae1a79511
> part/completion/katecompletionmodel.h 5fedbccc37cd49b7403827dafce15b498e99b160
>
> Diff: https://git.reviewboard.kde.org/r/113917/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Funk
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113917/">https://git.reviewboard.kde.org/r/113917/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is the performance good \
now? patch looks really promising, one small issue and one open question otherwise \
fine with me! Thanks!</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/113917/diff/3/?file=227631#file227631line340" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/completion/katecompletionmodel.h</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KATEPART_TESTS_EXPORT KateCompletionModel : public ExpandingWidgetModel</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">339</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt"><span \
class="hl">bool</span></span> <span class="nf">changeCompletions</span><span \
class="p">(</span><span class="n">Group</span><span class="o">*</span> <span \
class="n">g</span><span class="p">,</span> <span class="n">changeTypes</span> <span \
class="n">changeType</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">339</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt"><span class="hl">void</span></span> <span \
class="nf">changeCompletions</span><span class="p">(</span><span class="n"><span \
class="hl">KateCompletionModel</span></span><span class="o"><span \
class="hl">::</span></span><span class="n">Group</span><span class="o">*</span> <span \
class="n">g</span><span class="p">,</span> <span class="n">changeTypes</span> <span \
class="n">changeType</span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="kt"><span class="hl">bool</span></span><span \
class="hl"> </span><span class="n"><span class="hl">notifyModel</span></span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">explicit \
qualification of the identifier is not required here (probably KDevelop added \
it?)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/113917/diff/3/?file=227632#file227632line1590" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/completion/katecompletionmodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KateCompletionModel::setSortingCaseSensitivity( Qt::CaseSensitivity cs )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1571</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">beginResetModel</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is \
called above just after a begin/endReset. Thus potentially this could be merged into \
that section yielding a potential performance gain as the view doesn't have to \
react twice on the reset?</pre> </div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On December 28th, 2013, 10:54 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Milian Wolff.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 10:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=236948">236948</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">WIP: Fix crash in ~QPersistentIndex</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/completion/katecompletionmodel.cpp <span style="color: \
grey">(3fa8080ff95deb1e24327063ccd19dbb13ff49a8)</span></li>
<li>part/completion/katecompletionwidget.cpp <span style="color: \
grey">(4bb077e0973fd1eb9f1f5a7bb3e9bccae1a79511)</span></li>
<li>part/completion/katecompletionmodel.h <span style="color: \
grey">(5fedbccc37cd49b7403827dafce15b498e99b160)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113917/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic