| This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113917/ |
Is the performance good now? patch looks really promising, one small issue and one open question otherwise fine with me! Thanks!
| part/completion/katecompletionmodel.h (Diff revision 3) | |||
|---|---|---|---|
class KATEPART_TESTS_EXPORT KateCompletionModel : public ExpandingWidgetModel |
|||
| 339 | bool changeCompletions(Group* g, changeTypes changeType); |
339 | void changeCompletions(KateCompletionModel::Group* g, changeTypes changeType, bool notifyModel); |
explicit qualification of the identifier is not required here (probably KDevelop added it?)
| part/completion/katecompletionmodel.cpp (Diff revision 3) | |||
|---|---|---|---|
void KateCompletionModel::setSortingCaseSensitivity( Qt::CaseSensitivity cs ) |
|||
| 1571 | beginResetModel(); |
||
this is called above just after a begin/endReset. Thus potentially this could be merged into that section yielding a potential performance gain as the view doesn't have to react twice on the reset?
- Milian Wolff
On December 28th, 2013, 10:54 p.m. UTC, Kevin Funk wrote:
|
Review request for Kate and Milian Wolff.
By Kevin Funk.
Updated Dec. 28, 2013, 10:54 p.m.
Bugs:
236948
Repository:
kate
Description
Diffs
|