--===============6355910247189004738== Content-Type: multipart/alternative; boundary="===============2590566882233074727==" --===============2590566882233074727== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113917/#review46376 ----------------------------------------------------------- Is the performance good now? patch looks really promising, one small issue and one open question otherwise fine with me! Thanks! part/completion/katecompletionmodel.h explicit qualification of the identifier is not required here (probably KDevelop added it?) part/completion/katecompletionmodel.cpp this is called above just after a begin/endReset. Thus potentially this could be merged into that section yielding a potential performance gain as the view doesn't have to react twice on the reset? - Milian Wolff On Dec. 28, 2013, 10:54 p.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113917/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2013, 10:54 p.m.) > > > Review request for Kate and Milian Wolff. > > > Bugs: 236948 > http://bugs.kde.org/show_bug.cgi?id=236948 > > > Repository: kate > > > Description > ------- > > WIP: Fix crash in ~QPersistentIndex > > > Diffs > ----- > > part/completion/katecompletionmodel.cpp 3fa8080ff95deb1e24327063ccd19dbb13ff49a8 > part/completion/katecompletionwidget.cpp 4bb077e0973fd1eb9f1f5a7bb3e9bccae1a79511 > part/completion/katecompletionmodel.h 5fedbccc37cd49b7403827dafce15b498e99b160 > > Diff: https://git.reviewboard.kde.org/r/113917/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Funk > > --===============2590566882233074727== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113917/

Is the performance good now? patch looks really promising, one small issue and one open question otherwise fine with me! Thanks!

part/completion/katecompletionmodel.h (Diff revision 3)

class KATEPART_TESTS_EXPORT KateCompletionModel : public ExpandingWidgetModel

339

    bool changeCompletions(Group* g, changeTypes changeType);

339

    void changeCompletions(KateCompletionModel::Group* g, changeTypes changeType, bool notifyModel);

explicit qualification of the identifier is not required here (probably KDevelop added it?)

part/completion/katecompletionmodel.cpp (Diff revision 3)
void KateCompletionModel::setSortingCaseSensitivity( Qt::CaseSensitivity cs )
		1571	beginResetModel();

this is called above just after a begin/endReset. Thus potentially this could be merged into that section yielding a potential performance gain as the view doesn't have to react twice on the reset?

- Milian Wolff

On December 28th, 2013, 10:54 p.m. UTC, Kevin Funk wrote:

Review request for Kate and Milian Wolff.

By Kevin Funk.

Updated Dec. 28, 2013, 10:54 p.m.

Bugs: 236948

Repository: kate

Description

WIP: Fix crash in ~QPersistentIndex

Diffs

part/completion/katecompletionmodel.cpp (3fa8080ff95deb1e24327063ccd19dbb13ff49a8)
part/completion/katecompletionwidget.cpp (4bb077e0973fd1eb9f1f5a7bb3e9bccae1a79511)
part/completion/katecompletionmodel.h (5fedbccc37cd49b7403827dafce15b498e99b160)

--===============2590566882233074727==-- --===============6355910247189004738== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============6355910247189004738==--