[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 109476: add draw-caret to the config interface
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2013-04-17 11:36:50
Message-ID: 20130417113650.24978.44116 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109476/#review31213
-----------------------------------------------------------
Eli, either you commit this and close the review request with Christoph's blessing, \
or you close it as rejected with my blessing ;) But we'd like to get this resolved in \
one way or another.
- Dominik Haumann
On March 14, 2013, 6:38 a.m., Eli MacKenzie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109476/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 6:38 a.m.)
>
>
> Review request for Kate.
>
>
> Description
> -------
>
> KDevelop uses KTextEditor in for display only in the navigation widget, but the \
> text is marred by a caret that serves no purpose as the widget cannot accept \
> keyboard focus. I found no way to disable it through any interface, so I've added \
> it to the config interface. While its true that KateRenderer::setDrawCaret is not a \
> config element, it seems the config interface is the equivalent of QObject \
> properties so there aren't any side effects.
>
> Diffs
> -----
>
> ktexteditor/configinterface.h b4b08b2e905cbe407eeef5f5d6d72719f83cea33
> part/view/kateview.cpp cf9ccb0c848a17e8905f7d852fb8c6806db47fec
>
> Diff: http://git.reviewboard.kde.org/r/109476/diff/
>
>
> Testing
> -------
>
> Tested with KDevelop, the macro navigation widget looks better.
>
>
> File Attachments
> ----------------
>
> Screenshot (before)
> http://git.reviewboard.kde.org/media/uploaded/files/2013/03/14/no-draw-caret.png
> Sceenshot (after)
> http://git.reviewboard.kde.org/media/uploaded/files/2013/03/14/with-draw-caret.png
>
>
> Thanks,
>
> Eli MacKenzie
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109476/">http://git.reviewboard.kde.org/r/109476/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Eli, either you commit \
this and close the review request with Christoph's blessing, or you close it as \
rejected with my blessing ;) But we'd like to get this resolved in one way or \
another.</pre> <br />
<p>- Dominik</p>
<br />
<p>On March 14th, 2013, 6:38 a.m. UTC, Eli MacKenzie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Eli MacKenzie.</div>
<p style="color: grey;"><i>Updated March 14, 2013, 6:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KDevelop uses KTextEditor in for display only in the navigation widget, \
but the text is marred by a caret that serves no purpose as the widget cannot accept \
keyboard focus. I found no way to disable it through any interface, so I've added \
it to the config interface. While its true that KateRenderer::setDrawCaret is not a \
config element, it seems the config interface is the equivalent of QObject properties \
so there aren't any side effects.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with KDevelop, the macro navigation widget looks better.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ktexteditor/configinterface.h <span style="color: \
grey">(b4b08b2e905cbe407eeef5f5d6d72719f83cea33)</span></li>
<li>part/view/kateview.cpp <span style="color: \
grey">(cf9ccb0c848a17e8905f7d852fb8c6806db47fec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109476/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/03/14/no-draw-caret.png">Screenshot \
(before)</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/03/14/with-draw-caret.png">Sceenshot \
(after)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic