[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Re: [kate] part/document: add "New file" message for locally non-existing files
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2013-04-17 11:43:31
Message-ID: 2566751.WAfISsOdeg () obiwan
[Download RAW message or body]

On Tuesday, April 16, 2013 20:03:41 Albert Astals Cid wrote:
> El Dimarts, 16 d'abril de 2013, a les 17:54:20, Dominik Haumann va escriure:
> > Git commit 68cac271165d400919671fbfc801d56b8316093d by Dominik Haumann.
> > Committed on 16/04/2013 at 17:54.
> > Pushed by dhaumann into branch 'master'.
> > 
> > add "New file" message for locally non-existing files
> > 
> > Albert, since you commented in this previously: If you
> > think this totally sucks, we can revert. Could you give
> > it a try?
> 
> Any reason it needs to be a warning?

i) because it warns the user that the file does not exist.
   Maybe the user made a typo.
ii) because 'Positive' doesn't seem to fit, especially since
   it shows a tick ✓
iii) becase 'Information' uses a blue background which unfortunately
   gives a rather bad contrast

It's not that it says "WARNING" it large and bold letters, it' still decent, 
so I don't see a reason to change it.

Cheers,
Dominik

> > The message vanishes as soon as you scroll,
> > resize or type something.
> > 
> > CCMAIL: aacid@kde.org
> > CCMAIL: kwrite-devel@kde.org
> > 
> > M  +5    -0    part/document/katebuffer.cpp
> > 
> > http://commits.kde.org/kate/68cac271165d400919671fbfc801d56b8316093d
> > 
> > diff --git a/part/document/katebuffer.cpp b/part/document/katebuffer.cpp
> > index f240b34..e65966c 100644
> > --- a/part/document/katebuffer.cpp
> > +++ b/part/document/katebuffer.cpp
> > @@ -186,6 +186,11 @@ bool KateBuffer::openFile (const QString &m_file,
> > bool
> > enforceTextCodec) */
> > 
> >    if (m_doc->url().isLocalFile() && !QFile::exists (m_file)) {
> >    
> >      clear ();
> > 
> > +    KTextEditor::Message* message = new
> > KTextEditor::Message(KTextEditor::Message::Warning, +
> > 
> >                                       i18nc("short translation, user
> > 
> > created new file", "New file")); +
> > message->setPosition(KTextEditor::Message::TopInView);
> > +    message->setAutoHide(1000);
> > +    m_doc->postMessage(message);
> > 
> >      return true;

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread]