From kwrite-devel Wed Apr 17 11:36:50 2013 From: "Dominik Haumann" Date: Wed, 17 Apr 2013 11:36:50 +0000 To: kwrite-devel Subject: Re: Review Request 109476: add draw-caret to the config interface Message-Id: <20130417113650.24978.44116 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=136619862732031 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3310541375774157930==" --===============3310541375774157930== Content-Type: multipart/alternative; boundary="===============7812851095607151659==" --===============7812851095607151659== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109476/#review31213 ----------------------------------------------------------- Eli, either you commit this and close the review request with Christoph's blessing, or you close it as rejected with my blessing ;) But we'd like to get this resolved in one way or another. - Dominik Haumann On March 14, 2013, 6:38 a.m., Eli MacKenzie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109476/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 6:38 a.m.) > > > Review request for Kate. > > > Description > ------- > > KDevelop uses KTextEditor in for display only in the navigation widget, but the text is marred by a caret that serves no purpose as the widget cannot accept keyboard focus. I found no way to disable it through any interface, so I've added it to the config interface. While its true that KateRenderer::setDrawCaret is not a config element, it seems the config interface is the equivalent of QObject properties so there aren't any side effects. > > > Diffs > ----- > > ktexteditor/configinterface.h b4b08b2e905cbe407eeef5f5d6d72719f83cea33 > part/view/kateview.cpp cf9ccb0c848a17e8905f7d852fb8c6806db47fec > > Diff: http://git.reviewboard.kde.org/r/109476/diff/ > > > Testing > ------- > > Tested with KDevelop, the macro navigation widget looks better. > > > File Attachments > ---------------- > > Screenshot (before) > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/14/no-draw-caret.png > Sceenshot (after) > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/14/with-draw-caret.png > > > Thanks, > > Eli MacKenzie > > --===============7812851095607151659== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109476/ 

Eli, either you commit this and close the review request with Christoph's blessing, or you close it as rejected with my blessing ;) But we'd like to get this resolved in one way or another.

- Dominik


On March 14th, 2013, 6:38 a.m. UTC, Eli MacKenzie wrote:

Review request for Kate.
By Eli MacKenzie.

Updated March 14, 2013, 6:38 a.m.

Description 

KDevelop uses KTextEditor in for display only in the navigation widget, but the text is marred by a caret that serves no purpose as the widget cannot accept keyboard focus. I found no way to disable it through any interface, so I've added it to the config interface. While its true that KateRenderer::setDrawCaret is not a config element, it seems the config interface is the equivalent of QObject properties so there aren't any side effects.

Testing 

Tested with KDevelop, the macro navigation widget looks better.

Diffs

  • ktexteditor/configinterface.h (b4b08b2e905cbe407eeef5f5d6d72719f83cea33)
  • part/view/kateview.cpp (cf9ccb0c848a17e8905f7d852fb8c6806db47fec)

View Diff

File Attachments

--===============7812851095607151659==-- --===============3310541375774157930== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============3310541375774157930==--