'Review Request: change 1/3 of C-style casts to their equivalent C++ static_cast<>()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request: change 1/3 of C-style casts to their equivalent C++ static_cast<>()
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2012-06-03 10:24:20
Message-ID: 20120603102420.15718.9092 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105140/
-----------------------------------------------------------

Review request for Kate.

Description
-------

C++ casts are preferred over C-style casts (among other things, for their e=
asier search/replace).
If you like it, I'll change the other 2/3 of C-style casts without review.

Diffs
-----

  kate/plugins/filetemplates/plugin/filetemplates.cpp 3b780f6 =

  kate/app/kateapp.cpp ce7219e =

  kate/app/katemwmodonhddialog.cpp 925b7d0 =

  kate/app/katesavemodifieddialog.cpp 042e8e1 =

  kate/app/katesession.cpp e73a015 =

  kate/app/kateviewmanager.cpp 6449777 =

  kate/plugins/externaltools/kateexternaltools.cpp a8fdfe6 =

  kate/plugins/filebrowser/katefilebrowserconfig.cpp ce2148a =

  kate/plugins/filebrowser/katefilebrowserplugin.cpp da7c5fc =

Diff: http://git.reviewboard.kde.org/r/105140/diff/

Testing
-------

Only syntax changes, same generated code.

Thanks,

Jaime Torres Amate

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105140/">http://git.reviewboard.kde.org/r/105140/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Jaime Torres Amate.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">C++ casts are preferred over C-style casts (among other things, for \
their easier search/replace). If you like it, I&#39;ll change the other 2/3 of \
C-style casts without review.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Only syntax changes, same generated code.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/plugins/filetemplates/plugin/filetemplates.cpp <span style="color: \
grey">(3b780f6)</span></li>

 <li>kate/app/kateapp.cpp <span style="color: grey">(ce7219e)</span></li>

 <li>kate/app/katemwmodonhddialog.cpp <span style="color: grey">(925b7d0)</span></li>

 <li>kate/app/katesavemodifieddialog.cpp <span style="color: \
grey">(042e8e1)</span></li>

 <li>kate/app/katesession.cpp <span style="color: grey">(e73a015)</span></li>

 <li>kate/app/kateviewmanager.cpp <span style="color: grey">(6449777)</span></li>

 <li>kate/plugins/externaltools/kateexternaltools.cpp <span style="color: \
grey">(a8fdfe6)</span></li>

 <li>kate/plugins/filebrowser/katefilebrowserconfig.cpp <span style="color: \
grey">(ce2148a)</span></li>

 <li>kate/plugins/filebrowser/katefilebrowserplugin.cpp <span style="color: \
grey">(da7c5fc)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105140/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 