From kwrite-devel Sun Jun 03 10:24:20 2012 From: "Jaime Torres Amate" Date: Sun, 03 Jun 2012 10:24:20 +0000 To: kwrite-devel Subject: Review Request: change 1/3 of C-style casts to their equivalent C++ static_cast<>() Message-Id: <20120603102420.15718.9092 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=133882806627972 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0704551010565755731==" --===============0704551010565755731== Content-Type: multipart/alternative; boundary="===============6899854834637239782==" --===============6899854834637239782== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105140/ ----------------------------------------------------------- Review request for Kate. Description ------- C++ casts are preferred over C-style casts (among other things, for their e= asier search/replace). If you like it, I'll change the other 2/3 of C-style casts without review. Diffs ----- kate/plugins/filetemplates/plugin/filetemplates.cpp 3b780f6 = kate/app/kateapp.cpp ce7219e = kate/app/katemwmodonhddialog.cpp 925b7d0 = kate/app/katesavemodifieddialog.cpp 042e8e1 = kate/app/katesession.cpp e73a015 = kate/app/kateviewmanager.cpp 6449777 = kate/plugins/externaltools/kateexternaltools.cpp a8fdfe6 = kate/plugins/filebrowser/katefilebrowserconfig.cpp ce2148a = kate/plugins/filebrowser/katefilebrowserplugin.cpp da7c5fc = Diff: http://git.reviewboard.kde.org/r/105140/diff/ Testing ------- Only syntax changes, same generated code. Thanks, Jaime Torres Amate --===============6899854834637239782== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105140/

Review request for Kate.

By Jaime Torres Amate.

Descripti= on

C++ casts are preferred over C-style casts (among other thin=
gs, for their easier search/replace).
If you like it, I'll change the other 2/3 of C-style casts without revi=
ew.

Testing <= /h1>

Only syntax changes, same generated code.

Diffs=

kate/plugins/filetemplates/plugin/filetemplates.cpp (3b780f6)
kate/app/kateapp.cpp (ce7219e)
kate/app/katemwmodonhddialog.cpp (925b7d0)=
kate/app/katesavemodifieddialog.cpp (042e8= e1)
kate/app/katesession.cpp (e73a015)<= /li>
kate/app/kateviewmanager.cpp (6449777)
kate/plugins/externaltools/kateexternaltools.cpp (a8fdfe6)
kate/plugins/filebrowser/katefilebrowserconfig.cpp (ce2148a)
kate/plugins/filebrowser/katefilebrowserplugin.cpp (da7c5fc)

View Diff

--===============6899854834637239782==-- --===============0704551010565755731== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============0704551010565755731==--